Bug 487357 - [find/replace] Content of FindReplaceDialog is hidden
Summary: [find/replace] Content of FindReplaceDialog is hidden
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.4   Edit
Hardware: All All
: P5 enhancement (vote)
Target Milestone: 4.6 M7   Edit
Assignee: Christian Georgi CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks: 494939
  Show dependency tree
 
Reported: 2016-02-05 11:35 EST by Christian Georgi CLA
Modified: 2016-05-30 16:15 EDT (History)
2 users (show)

See Also:
daniel_megert: review+

Attachments
Current look (17.53 KB, image/png)
2016-02-05 11:36 EST, Christian Georgi CLA 		no flags Details
New look, note the scrollbars (17.49 KB, image/png)
2016-02-05 11:37 EST, Christian Georgi CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Georgi CLA 2016-02-05 11:35:53 EST 
The contents of the FindReplaceDialog is completely hidden if it is resized to a small size.  This often leads to users not being aware that there are options which influence the search operation.  For example users might wonder why only whole words are found, and they do not see the corresponding option.
See a screenshot attached demonstrating such a clipped dialog.

As a fix I propose to make the dialog contents scrollable to indicate that there is more content.  See second screenshot for how this will look.
Comment 1 Christian Georgi CLA 2016-02-05 11:36:30 EST 
Created attachment 259599 [details]
Current look
Comment 2 Christian Georgi CLA 2016-02-05 11:37:02 EST 
Created attachment 259600 [details]
New look, note the scrollbars
Comment 3 Dani Megert CLA 2016-02-05 11:39:50 EST 
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=474850#c2 why it is like that.

I'd have to see/feel how the dialog looks like with a scroll bar.
Comment 4 Eclipse Genie CLA 2016-02-05 11:43:19 EST 
New Gerrit change created: https://git.eclipse.org/r/66036
Comment 5 Christian Georgi CLA 2016-02-05 11:47:10 EST 
I was able to solve the issue with the dialog's initial size by just removing the dialog's custom implementation of getInitialSize().
It now feels like I would expect it: users can work with it at small sizes, it stores its size, and shows scrollbars.
Comment 6 Christian Georgi CLA 2016-04-25 02:59:54 EDT 
4.7... Sadly this move of even small-sized and "helpwanted" patches reflects the perceived state of Eclipse.  Not exactly what I would call a motivation to do more...
Comment 7 Dani Megert CLA 2016-04-25 07:38:57 EDT 
(In reply to Christian Georgi from comment #6)
> 4.7... Sadly this move of even small-sized and "helpwanted" patches reflects
> the perceived state of Eclipse.  Not exactly what I would call a motivation
> to do more...

I agree.
Comment 9 Christian Georgi CLA 2016-04-25 07:48:23 EDT 
Thanks for reviewing this!
Comment 10 Christian Georgi CLA 2016-04-26 04:00:49 EDT 
Verified in I20160425-1300
Comment 11 Markus Keller CLA 2016-05-30 12:32:03 EDT 
The problem with such small fixes is that there's usually one or more follow-up problems like bug 494939.
Comment 12 Christian Georgi CLA 2016-05-30 16:15:29 EDT 
(In reply to Markus Keller from comment #11)
> The problem with such small fixes is that there's usually one or more
> follow-up problems like bug 494939.

Yes, and we will fix follow-up issues as we have always done ;)
No reason not do try to make this better in the first place...