Community
Participate
Working Groups
Hi, when sanity checking all views of my Neon M5 installation as part of testing the Eclipse IDE for Java Developers EPP package, I stumbled upon the "Classic Search" view. Is this still needed? (I have been using Eclipse for year, as never seen it before.) AFAICT, I can't even start a search whose results will be displayed there instead of in the modern "Search" view. In particular, the "Search" button in the "Classic Search" view *itself* starts a search whose results are shown in the "Search" view.
(In reply to Andreas Sewe from comment #0) > Hi, > > when sanity checking all views of my Neon M5 installation as part of testing > the Eclipse IDE for Java Developers EPP package, I stumbled upon the > "Classic Search" view. Is this still needed? (I have been using Eclipse for > year, as never seen it before.) > > AFAICT, I can't even start a search whose results will be displayed there > instead of in the modern "Search" view. In particular, the "Search" button > in the "Classic Search" view *itself* starts a search whose results are > shown in the "Search" view. All old plug-ins that offer search and did not migrate would stop working.
(In reply to Dani Megert from comment #1) >> AFAICT, I can't even start a search whose results will be displayed there >> instead of in the modern "Search" view. In particular, the "Search" button >> in the "Classic Search" view *itself* starts a search whose results are >> shown in the "Search" view. > > All old plug-ins that offer search and did not migrate would stop working. Fair enough. AFAICT, it has been deprecated since 3.0, so I was just wondering if there were any plans to remove it in the future. Apparently not.
It's time to reconsider this IMHO.
(In reply to Alexander Kurtakov from comment #3) > It's time to reconsider this IMHO. +1
As this has been deprecated for "software ages" I'm going to remove for 4.22 M2.
(In reply to Alexander Kurtakov from comment #5) > As this has been deprecated for "software ages" I'm going to remove for 4.22 > M2. I have no idea what that is and if that is used by anyone, but please announce this on cross project list, with info what exactly is removed (API, view id, possible extension points etc). The people should know where to look for possible breakage.
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/186120
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/186121
(In reply to Andrey Loskutov from comment #6) > (In reply to Alexander Kurtakov from comment #5) > > As this has been deprecated for "software ages" I'm going to remove for 4.22 > > M2. > > I have no idea what that is and if that is used by anyone, but please > announce this on cross project list, with info what exactly is removed (API, > view id, possible extension points etc). The people should know where to > look for possible breakage. Done.
https://www.eclipse.org/lists/cross-project-issues-dev/msg18657.html
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/186120 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=bca70eaca7f2f90cdb07d5ae549fe28e5cc0d6f4
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/186121 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=c08b0fe8204636808e25ea5b88e6a9ce218d619d
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/186526
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.common/+/186527
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/186526 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=d7ee493d0cb6496fd0e1b915765ec05b2479b83a
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.common/+/186527 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=964d0a51b8d498ce69e221ce481cb4391658fa50
Alex, is this done?
