Community
Participate
Working Groups
If you click the downarrow on the "show previous searches" option, a list of all previous searches is shown below the cursor, and then you can easily choose any of the previous searches. Or you can show the history in a separate window or you can choose "Clear History". So far so good. But if the list of searches is long, and the clickpoint is near the bottom of the screen, the described list is shown upwards, but NOT above the cursor, but with the cursor positioned on the last choice: "Clear History". If you happen to release the mouse button then and there, you have selected Clear History, and all your previous searches are unintentionally erased. This has happened to me on more than one occasion. Very annoying. I suggest showing the list ABOVE the cursor in this case so this mistake cannot be made any more.
(In reply to Jan de Ruiter from comment #0) > If you click the downarrow on the "show previous searches" option, a list of > all previous searches is shown below the cursor, and then you can easily > choose any of the previous searches. > Or you can show the history in a separate window or you can choose "Clear > History". So far so good. > But if the list of searches is long, and the clickpoint is near the bottom > of the screen, the described list is shown upwards, but NOT above the > cursor, but with the cursor positioned on the last choice: "Clear History". > If you happen to release the mouse button then and there, you have selected > Clear History, and all your previous searches are unintentionally erased. > This has happened to me on more than one occasion. Very annoying. > I suggest showing the list ABOVE the cursor in this case so this mistake > cannot be made any more. The OS handles this, i.e. where/how to place the menu if it doesn't fit.
>The OS handles this, i.e. where/how to place the menu if it doesn't fit. So it is either completely below the cursor, or above the cursor with the cursor on the last entry, which is not controlled by eclipse? Then a solution would be to exchange the last two entries. Then the worst that can happen is an unintentional showing of the complete list in a separate popup.
(In reply to Jan de Ruiter from comment #2) > Then a solution would be to exchange the last two entries. No, that's not a good solution for 80% of the users. We could show a warning dialog before clearing (one with 'never ask again').
(In reply to Dani Megert from comment #3) > (In reply to Jan de Ruiter from comment #2) > > Then a solution would be to exchange the last two entries. > > No, that's not a good solution for 80% of the users. We could show a warning > dialog before clearing (one with 'never ask again'). Sounds OK to me.
New Gerrit change created: https://git.eclipse.org/r/70820
Sorry, this slipped through the crack.
The new Gerrit change https://git.eclipse.org/r/#/c/70820/ reports 'cannot merge'. So what happened to the change? Did it get incorporated into the master? It seems to me that it didn't. And what did the code review verify?
(In reply to Jan de Ruiter from comment #7) > The new Gerrit change https://git.eclipse.org/r/#/c/70820/ reports 'cannot > merge'. So what happened to the change? See the status at the top left: Change 70820 - Needs Code-Review Label > master? It seems to me that it didn't. And what did the code review verify? This looks like a a hiccup on Hudson - it should only verify. As you can see the build is marked Unstable. Simply retrigger it again.
>Simply retrigger it again. I have no idea how to achieve that. Sorry.
(In reply to Jan de Ruiter from comment #9) > >Simply retrigger it again. > I have no idea how to achieve that. Sorry. I've rebased the change.
(In reply to Dani Megert from comment #10) > (In reply to Jan de Ruiter from comment #9) > > >Simply retrigger it again. > > I have no idea how to achieve that. Sorry. > > I've rebased the change. Thanks. All it needs now is a code review.
Robert, sorry for the delay. I've reviewed it now.
(In reply to Dani Megert from comment #12) > Robert, sorry for the delay. I've reviewed it now. Robert, it's in your bucket now.
This still happens in 2019-09 (haven't tried 2020-03 yet) and is very annoying. Any chance to have that fix in the next release?
I have updated the changeset with the changes requested by the reviewer, but rebase doesn't work, so I don't really know how to fix it. Probably the easiest way would be to recreate the changeset based on current master, and abandon the old one (which I forgot about, so only realized it exists when the Abandoned message came earlier today).
Patchset updated based on latest master according to Dani Megert's request not using a preference anymore, using the "Do not show this &message again" text, as requested, also updated the default checkbox value (as Do not show this checkbox is exactly the opposite of Always show this confirmation, as in the initial request). Hopefully I will not miss the notification next time.
Thank you Jan for reporting and Robert for fixing!
Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/70820 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=b7afb46b4a3ad50a4f9107cf6c0197864233f491
So it got fixed finally after 5 years. Congratulations to everybody involved.
