Bug 486859 - Editor Selection dialog should offer one-click "for all *.xyz files"
Summary: Editor Selection dialog should offer one-click "for all *.xyz files"
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.7 M2   Edit
Assignee: Patrik Suzzi CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on: 378485 463262
Blocks:
  Show dependency tree
 
Reported: 2016-01-29 12:18 EST by Markus Keller CLA
Modified: 2016-09-08 04:09 EDT (History)
6 users (show)

See Also:
daniel_megert: review? (markus.kell.r)

Attachments
Editor selection - extension for all files (145.22 KB, image/gif)
2016-01-30 16:08 EST, Patrik Suzzi CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2016-01-29 12:18:00 EST 
The Editor Selection dialog should offer a one-click option for
"for all *.xyz files".

The usual pattern for such situation is to use exclusive checkboxes like this (checking one box unchecks the other one):

Use this editor for:
[ ] all 'FileName.ext' files
[ ] all '*.ext' files

That '*.ext' contains 'FileName.ext' is not a justification for an inconvenient UI.
Comment 1 Lars Vogel CLA 2016-01-29 12:28:33 EST 
+1
Comment 2 Patrik Suzzi CLA 2016-01-30 16:08:06 EST 
Created attachment 259462 [details]
Editor selection - extension for all files

I'm going to submit a solution working as requested. 
See attached image to check the behavior.
Comment 3 Eclipse Genie CLA 2016-01-30 16:11:23 EST 
New Gerrit change created: https://git.eclipse.org/r/65513
Comment 4 Patrik Suzzi CLA 2016-04-22 17:37:17 EDT 
Lars, hope you don't mind if I ask you to review the attached change.
Comment 5 Lars Vogel CLA 2016-04-23 02:30:30 EDT 
Patrik, please ask Andrey or Mickael. I was not involved in the default editor work.
Comment 6 Lars Vogel CLA 2016-04-25 15:10:33 EDT 
Mass move to 4.6 RC1. We might push out more to 4.7.
Comment 7 Andrey Loskutov CLA 2016-04-28 04:41:16 EDT 
(In reply to Lars Vogel from comment #6)
> Mass move to 4.6 RC1. We might push out more to 4.7.

This is actually an enhancement, not a bug. 

Lars, as we are in process to declare M7 (see bug 492625) we would need another respin request for merging this (in case we get the review through)?
Comment 8 Lars Vogel CLA 2016-04-28 04:47:58 EDT 
(In reply to Andrey Loskutov from comment #7)
> (In reply to Lars Vogel from comment #6)
> > Mass move to 4.6 RC1. We might push out more to 4.7.
> 
> This is actually an enhancement, not a bug. 
> 
> Lars, as we are in process to declare M7 (see bug 492625) we would need
> another respin request for merging this (in case we get the review through)?

I have scheduled a respin for today, 4/28, at 8 AM Eastern, see releng mailing list. If you want to merge this, please send a email to releng, for any additional feature work I don't think releng will respin again. 

I have not followed the editor selection discussion in detail, so I'm not sure how important this change is for 4.6. As you say it is a feature, I would suggest to wait for RC1 and check with the PMC, if that can be approved.
Comment 9 Patrik Suzzi CLA 2016-09-01 03:10:42 EDT 
Mickael, hope you don't mind reviewing this.
Comment 11 Patrik Suzzi CLA 2016-09-01 04:16:06 EDT 
Thanks, closing as Fixed.
Please, re-open if you think we need N&N entry
Comment 12 Lars Vogel CLA 2016-09-01 04:58:24 EDT 
(In reply to Patrik Suzzi from comment #11)
> Please, re-open if you think we need N&N entry

Sounds noteworthy to me.
Comment 13 Eclipse Genie CLA 2016-09-01 05:57:17 EDT 
New Gerrit change created: https://git.eclipse.org/r/80194