486777 – ResourceInfoPage should contain a "go to directory" button for the location

Bug 486777 - ResourceInfoPage should contain a "go to directory" button for the location

Summary: ResourceInfoPage should contain a "go to directory" button for the location

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	4.6
Hardware:	PC All

Importance:	P3 normal (vote)
Target Milestone:	4.6 M6
Assignee:	Simon Scholz
QA Contact:

URL:
Whiteboard:
Keywords:	noteworthy

Depends on:	487772
Blocks:
	Show dependency tree

Reported:	2016-01-28 16:43 EST by Simon Scholz
Modified:	2016-03-15 07:40 EDT (History)
CC List:	4 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Git Commit 489603

Attachments
Go to directory button in ResourceInfoPage (68.04 KB, image/png) 2016-01-28 16:43 EST, Simon Scholz	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Simon Scholz

2016-01-28 16:43:59 EST

Created attachment 259440 [details]
Go to directory button in ResourceInfoPage

I've heard that a popup menu item for going to a project's directory is not desired. But I often right click a project and then have to copy the file/folder location and open a file browser by myself.
Therefore I think it's more convenient to at least offer a button right behind the locationvalue.

See attached screenshot.

Comment 1 Eclipse Genie

2016-01-28 17:01:27 EST

New Gerrit change created: https://git.eclipse.org/r/65414

Comment 2 Lars Vogel

2016-01-28 17:11:16 EST

Looks good.

Could we maybe add also Entry to the open with menu? Open with -> System File Explorer?

Comment 3 Simon Scholz

2016-01-28 17:17:14 EST

(In reply to Lars Vogel from comment #2)
> Looks good.
> 
> Could we maybe add also Entry to the open with menu? Open with -> System
> File Explorer?

Directories, such as Projects, do not have an "Open With" menu. But both of them have a "Show In" menu, which IMHO could be used for this.

I'll create a new bug for it.

Comment 4 Eclipse Genie

2016-02-13 06:24:15 EST

Gerrit change https://git.eclipse.org/r/65414 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2e5c5e1c8b72d92c8cc531a8bd5f0b8585cc4e94

Comment 5 Simon Scholz

2016-02-13 06:27:05 EST

Now this patch is using the ShowInSystemExplorerHandler to open the resource.

Comment 6 Markus Keller

2016-02-22 06:35:16 EST

Doesn't work in 4.6.0.I20160216-1400:

Scenarios:
- open an editor
- choose "File > Properties" or "Project > Properties"
- click button
=> nothing happens

Comment 7 Lars Vogel

2016-03-10 04:07:43 EST

@Simon, please fix that for M6

Comment 8 Eclipse Genie

2016-03-13 20:25:13 EDT

New Gerrit change created: https://git.eclipse.org/r/68309

Comment 9 Eclipse Genie

2016-03-13 21:39:04 EDT

Gerrit change https://git.eclipse.org/r/68309 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f9c0b04f0dab099ca9aa4beacfb6809dd30cfdbc

Comment 10 Simon Scholz

2016-03-13 21:41:50 EDT

I've added a new command parameter to the org.eclipse.ui.category.navigate command, where the path of an IResource can be passed to the handler, which shows the IResource in the system explorer.

Comment 11 Eclipse Genie

2016-03-13 21:49:12 EDT

New Gerrit change created: https://git.eclipse.org/r/68313

Comment 12 Eclipse Genie

2016-03-13 23:07:50 EDT

Gerrit change https://git.eclipse.org/r/68313 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f6f8645596573c96d80df7802d815cceba572241

Comment 13 Andrey Loskutov

2016-03-15 03:45:17 EDT

This caused regression, see bug 489603.