Bug 486740 - DefaultDependencyCollector does not correctly handle dependency management.
Summary: DefaultDependencyCollector does not correctly handle dependency management.
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Aether (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-28 11:15 EST by Christian Schulte CLA
Modified: 2017-02-23 14:08 EST (History)
0 users

See Also:


Attachments
Patch correcting the order 'DependencyManager' and 'DependencySelector' are called. (1.83 KB, patch)
2016-01-28 11:30 EST, Christian Schulte CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Schulte CLA 2016-01-28 11:15:56 EST

    
Comment 1 Christian Schulte CLA 2016-01-28 11:27:58 EST
During dependency processing the 'DependencySelector' is called to decide if a dependency is to be selected. The call to 'DependencySelector.selectDependency( dependency )' is performed with the unmanagement dependency but needs to be performed with the managed dependency. See the attached patch. With this patch applied, the result no longer contains dependencies whose scope or optionality has been managed to not be part of the result (correct behaviour). Without this patch applied, the result contains dependencies with a managed scope or optionality not filtered out by the 'DependencySelector' in use (incorrect behaviour).
Comment 2 Christian Schulte CLA 2016-01-28 11:30:46 EST
Created attachment 259437 [details]
Patch correcting the order 'DependencyManager' and 'DependencySelector' are called.