Bug 485919 - Use default weight consistently in SashRenderer
Summary: Use default weight consistently in SashRenderer
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2016-01-15 06:22 EST by Lars Vogel CLA
Modified: 2019-05-30 17:43 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lars Vogel CLA 2016-01-15 06:22:00 EST 
The logic in SashRenderer for determining the layout weight, looks "weird". 

childRendered calls getLayoutWeight which already set a default if not maintained hard coded to "10000". If a value is found but not parsable it returns UNDEFINED_WEIGHT and the value is set to DEFAULT_WEIGHT which is 5000.

We should simplify this and always use DEFAULT_WEIGHT.
Comment 1 Andrew Obuchowicz CLA 2019-05-30 10:40:27 EDT 
This bug appears to have been fixed, see https://git.eclipse.org/r/#/c/67136/
Comment 2 Dani Megert CLA 2019-05-30 10:42:49 EDT 
(In reply to Andrew Obuchowicz from comment #1)
> This bug appears to have been fixed, see https://git.eclipse.org/r/#/c/67136/
Lars?