Community
Participate
Working Groups
I have no idea why but commit https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=328d2f9ad8a06f4c7519c305ae43d008e7c628a0 ("Activating more UI tests that should be run regularly.") actually *disabled* lot of tests, for example PropertySheetTestSuite. Currently not enabled tests: PropertySheetTestSuite.class, QuickAccessTestSuite.class, InternalTestSuite.class, AdaptableTestSuite.class, ZoomTestSuite.class, DynamicPluginsTestSuite.class, MultiPageEditorTestSuite.class, CommandsTestSuite.class, ContextsTestSuite.class, DragTestSuite.class, IntroTestSuite.class, MenusTestSuite.class, PresentationsTestSuite.class, LeakTests.class, ConcurrencyTestSuite.class, MultiEditorTestSuite.class, FilteredTreeTests.class, StatusHandlingTestSuite.class, OpenSystemInPlaceEditorTest.class I've stumbled on this while fixing bug 485021 - if the PropertySheetTestSuite would be enabled in the UiTestSuite, we would immediately see the regression while fixing bug 479855. So I've enabled now PropertySheetTestSuite (it has *now* no failures) and plan to enable other "green" test suites unless somebody explains why they still should be disabled. Patch for re-enabling PropertySheetTestSuite follows.
New Gerrit change created: https://git.eclipse.org/r/63485
New Gerrit change created: https://git.eclipse.org/r/63486
New Gerrit change created: https://git.eclipse.org/r/63487
New Gerrit change created: https://git.eclipse.org/r/63488
New Gerrit change created: https://git.eclipse.org/r/63490
New Gerrit change created: https://git.eclipse.org/r/63493
New Gerrit change created: https://git.eclipse.org/r/63494
Gerrit change https://git.eclipse.org/r/63485 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=83a24e519b3fce56e3fe0685ef68dbd0f0c5af8a
Gerrit change https://git.eclipse.org/r/63486 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=34a6365c26596e7dc1be6d991c7da16121265ace
Gerrit change https://git.eclipse.org/r/63487 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ed791351c638c6394decd6c30741efe690cbb53a
Gerrit change https://git.eclipse.org/r/63488 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d19b935ed4f039359b5d7dee7a8dc22d06fcffba
Gerrit change https://git.eclipse.org/r/63490 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=fb53d556cae5e91da5fb7a097868ae6e6420cee8
Gerrit change https://git.eclipse.org/r/63493 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=408bec5ad43a311f3114f630b591bca8037b5da2
Gerrit change https://git.eclipse.org/r/63494 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f54456ab9f0aba7aed27e4ebadf8172a4e324850
Giving back to UI team, I'm not planning to continue here yet (no time). TODO: check which tests can be enabled from the list below (see /org.eclipse.ui.tests/Eclipse UI Tests/org/eclipse/ui/tests/UiTestSuite.java): QuickAccessTestSuite.class, InternalTestSuite.class, ZoomTestSuite.class, DynamicPluginsTestSuite.class, CommandsTestSuite.class, DragTestSuite.class, IntroTestSuite.class, MenusTestSuite.class, PresentationsTestSuite.class, LeakTests.class, MultiEditorTestSuite.class, OpenSystemInPlaceEditorTest.class
While developing tests for BUG 543570 I noticed, that the InternalTestSuite.class is still disabled. But the tests would fit in there best. For that reason I will work on enabling it again now. Additionally we plan to provide patches for the other suites in the near future.
New Gerrit change created: https://git.eclipse.org/r/135681
Gerrit change https://git.eclipse.org/r/135681 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=35c5c7bd1d3f0d6b615998a9508c2226a6f62e53
New Gerrit change created: https://git.eclipse.org/r/137089
Gerrit change https://git.eclipse.org/r/137089 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=fc92d596be590fa40e39a54d5dc762fc8b53869a
I just noticed that the target platform that used is different, when running the tests with maven/tycho or when running with the provided launch configurations. Which makes some tests unstable. When the test are run by tycho, the only the plugins that the test plugin depends on are included, and some additional configured in the pom.xml. Also as no product or application is specified, the default application 'org.eclipse.ui.ide.workbench' is used. When using the launch configuration, all plugins in the workspace are included. As a result, also the example plugins end up in the dependencies. Some of those plugins influence the behavior of some tests, e.g., extra menu items are added. Also, for launching the 'org.eclipse.sdk.ide' product is used. For me it would be beneficial to bring the launch configurations in line with the tycho configuration. That is, change the product/application and only select the specific dependencies of the test plugin. This would require that the launch configuration is updated if any dependency (in the whole chain) is changed. I am not aware if this can be done automatically. Is it worth making these changes?
New Gerrit change created: https://git.eclipse.org/r/138905
New Gerrit change created: https://git.eclipse.org/r/139372
Also the session tests are currently broken, and not run automatically, see: UI-Session Tests.launch SessionTests.class
Gerrit change https://git.eclipse.org/r/139372 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e3bbb556534a1fb945e1036948325d14a8dd9c7a
Many of the failing tests are the leftovers of bug 351851; code was made to compile in the 4.2 branch, however, not all (many) testcases were made to work correctly afterwards. See for instance commit 412bb792f91ba461ddb4451860a72ff58cf8a279 and 88771cf53356ffabfbeab67c9db3ff068e2b60e5, among others
DynamicPluginsTestSuite fails due to dependencies on "Eclipse 2.0 Style Plugin Support", which has been removed, see Bug 520235.
MultiEditorTest fail due to 'Bug 396528 - [MPE] Incomplete implementation in AbstractMultiEditor', i.e. MultiEditor is not fully functional on E4 yet. Besides, the tests are unstable, see Bug 366522.
Gerrit change https://git.eclipse.org/r/136152 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=16878dac5975c02e372da15af1f2434a789ebf1c
Andrey, since you moved it back to the inbox (OK), I assume we also have to remove the target milestone, right?
(In reply to Dani Megert from comment #30) > Andrey, since you moved it back to the inbox (OK), I assume we also have to > remove the target milestone, right? I see no bandwidth on my side, right.
Gerrit change https://git.eclipse.org/r/138905 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=fa1d0fec98685334fb782363204ba785630bc9c9
New Gerrit change created: https://git.eclipse.org/r/142555
Bug 366451 - [Compatibility] many failures in ui.tests Seems to be the umbrella bug to get all UI tests to pass within the E4 context.
*** Bug 366541 has been marked as a duplicate of this bug. ***
Gerrit change https://git.eclipse.org/r/142555 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a2e31015e3353626e5d8fc9143e6395b0c84f22a
Bug 288358 disabled ProgressContantsTest.testKeepProperty. I've run the test successful on Windows and Linux. I assume something fixed the problem in the last 10 years.
New Gerrit change created: https://git.eclipse.org/r/152235
Gerrit change https://git.eclipse.org/r/152235 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=13c2a48f5a297a7804f467501eebd5cd4f6702ab
(In reply to Paul Pazderski from comment #37) > Bug 288358 disabled ProgressContantsTest.testKeepProperty. I've run the test > successful on Windows and Linux. I assume something fixed the problem in the > last 10 years. After some more tests I saw it sometimes failing. It is probably a timing problem in the test. UI has not always enough time to create the finished items.
New Gerrit change created: https://git.eclipse.org/r/152259
Gerrit change https://git.eclipse.org/r/152259 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1e8bf9847caf7828f11087a9a64851a7c2a8e625
(In reply to Eclipse Genie from comment #42) > Gerrit change https://git.eclipse.org/r/152259 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1e8bf9847caf7828f11087a9a64851a7c2a8e625 > The test ProgressContantsTest.testKeepOneProperty fails on windows intermittently. https://download.eclipse.org/eclipse/downloads/drops4/I20191120-1800/testresults/html/org.eclipse.ui.tests_ep414I-unit-win32-java8_win32.win32.x86_64_8.0.html
(In reply to Kalyan Prasad Tatavarthi from comment #43) > (In reply to Eclipse Genie from comment #42) > > Gerrit change https://git.eclipse.org/r/152259 was merged to [master]. > > Commit: > > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1e8bf9847caf7828f11087a9a64851a7c2a8e625 > > > > The test ProgressContantsTest.testKeepOneProperty fails on windows > intermittently. > https://download.eclipse.org/eclipse/downloads/drops4/I20191120-1800/ > testresults/html/org.eclipse.ui.tests_ep414I-unit-win32-java8_win32.win32. > x86_64_8.0.html Will check. But note that the quoted commit enabled the keep test and the failing one is the keepOne test from bug 552952.
(In reply to Kalyan Prasad Tatavarthi from comment #43) > The test ProgressContantsTest.testKeepOneProperty fails on windows > intermittently. > https://download.eclipse.org/eclipse/downloads/drops4/I20191120-1800/ > testresults/html/org.eclipse.ui.tests_ep414I-unit-win32-java8_win32.win32. > x86_64_8.0.html I have seen it fail on Jenkins too: https://ci.eclipse.org/platform/job/eclipse.platform.ui-Gerrit/20928/
I merged (In reply to Eclipse Genie from bug 552952 comment #5) > Gerrit change https://git.eclipse.org/r/153115 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=8df4811fb2a512fae7806b29b3c583325006f838 ProgressContantsTest.testKeepOneProperty should not fail anymore.
*** Bug 366451 has been marked as a duplicate of this bug. ***
*** Bug 381873 has been marked as a duplicate of this bug. ***
AFAICS we have Bug 366520, 366595, 366635, 549802 for the remaining tasks. As this bug is already very long and saw lots of commits, I close this one as fixed. If there are more tests to activate, please open new bug reports.
