Community
Participate
Working Groups
Created attachment 258719 [details] Eclipse 4.5.1 The line under the QuickAccess box is not visible anymore in 4.6. See screenshots for 4.5.1
Created attachment 258720 [details] No line in Eclipse 4.6
Created attachment 258728 [details] Quick Access line visible on I20151215-0800 What build is the line disappearing in? Attached is a screenshot of the latest I-build (20151215-0800) running on my system. A child Eclipse running on the latest master looks the same.
(In reply to Eric Williams from comment #2) > Created attachment 258728 [details] > Quick Access line visible on I20151215-0800 > > What build is the line disappearing in? > > Attached is a screenshot of the latest I-build (20151215-0800) running on my > system. A child Eclipse running on the latest master looks the same. I use 4.6.0.I20151215-0800 on Ubuntu 15.10 (plain).
(In reply to Lars Vogel from comment #3) > I use 4.6.0.I20151215-0800 on Ubuntu 15.10 (plain). I can see it now, you have to right click one of the perspective buttons, and check "Show Text". Once the text disappear the line does as well.
New Gerrit change created: https://git.eclipse.org/r/69275
Gerrit change https://git.eclipse.org/r/69275 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=de95e2ca9a623c4260b4f48866099a052f6848a4
(In reply to Eclipse Genie from comment #6) > Gerrit change https://git.eclipse.org/r/69275 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=de95e2ca9a623c4260b4f48866099a052f6848a4 Sorry it took me so long to get around to this fix. The solution is to adjust the padding for buttons that are children of toolbars. In total this will add 3px to the overall height of the toolbar. This is a marginal increase in my opinion as the lack of a line is more annoying. Pre-patch: Toolbar height (perspective buttons with text): 148px Toolbar height (perspective buttons without text): 146px Post patch: Toolbar height (perspective buttons with text): 151px Toolbar height (perspective buttons without text): 149px
Verified in 4.6.0.I20160428-0800. Thanks for the fix Eric!
I'm planning to remove the underline, as this reduces visual clutter and locks better. Once we have done this, I suggest to revert this change. Can we use this bug or shall I open a new one?
(In reply to Lars Vogel from comment #9) > I'm planning to remove the underline, as this reduces visual clutter and > locks better. Once we have done this, I suggest to revert this change. > > Can we use this bug or shall I open a new one? I would suggest opening a new bug instead of reopening this one as this fix continues to remain valid in Neon.
Lars, do you know which GTK3 version Ubuntu 15.10 has? Or can you validate that the patch https://git.eclipse.org/r/85143 on bug 507604 do not cause regression (on Ubuntu) to this one?
Andrey, sorry I updated my machines to 16.04.
