Community
Participate
Working Groups
Created attachment 258703 [details] Git patch - proposed fix Overview The marquee selection rectangle's foreground color is white, making it almost impossible to see. Steps to reproduce On a diagram that supports it, drag to select objects. The marquee selection rectangle is white, blending in with a white diagram background. It isn't visible unless it happens to cross a dark shape where there's enough contrast to see it. Expected Results The foreground color should be black by default. Build date & hardware Using HEAD of b0_12_x (dfc8de7 from 2015-09-21). OS is CentOS 6.7, 64-bit x86. Additional information I think this is just a coding error - I believe the foreground and background colors were unintentionally reversed in the code. I'm unsure if this renders better on other platforms. In any case, I've attached a patch with the simple, 2-line proposed fix.
Created attachment 258724 [details] Screenshot of marquee under Windows with current implementation
Created attachment 258725 [details] Screenshot of marquee under Windows with new implementation
Daniel, that is interesting... Under Windows I have the excatly opposite effect, see attached screenshots. "Screenshot of marquee under Windows with current implementation" shows the active Graphiti version, the marquee is visible; " Screenshot of marquee under Windows with new implementation" shows your version of the marquee tool (well, actually nothing can be seen...). From the coding this is strange, actually I would expect your implementation to be the correct one. But the coding we have here is active since the very beginning of Graphiti. Can you make screenshots of the Linux behavior? Currently I have no Linux installation running. Also I would like to cross-check Mac. As it seems we have different behaviors on the different platforms, which makes this hard to fix. Michael
That's very odd! I had looked at the history on the code and seen it was very old, so I was surprised no one had noticed or commented on this. I'll get you some screen shots. I'm also going to see if I can manage to use a CentOS 7 or other more modern Linux system for comparison.
Created attachment 258802 [details] CentOS6_original CentOS6 with current implementation
Created attachment 258803 [details] CentOS6_new CentOS6 after applying patch
The screenshots above should give a good feel. I tried to drag the box through some darker areas so you can see how the current implementation looks on CentOS 6. It does indeed draw - just as a white dotted line.
It was a long time back that I filed this, but in more recent history I've upgraded my desktop from CentOS 6 to 7. It dawned on me recently that the selection boxes were appearing correctly on my desktop. I checked with a coworker who still has a CentOS 6 desktop, and he still sees the problem. So - since CentOS 6 uses GTK 2, but I'm using GTK 3 on CentOS 7, I'm thinking this is more likely a SWT bug (not a Graphiti bug).
(In reply to Daniel Wille from comment #8) > So - since CentOS 6 uses GTK 2, but I'm using GTK 3 on CentOS 7, I'm > thinking this is more likely a SWT bug (not a Graphiti bug). Thanks Daniel for this update. I wanted to check this in more depths but I already had the same suspicion (see my comment above). I'll move this to the SWT queue.
GTK2 only bugs aren't being fixed as such development is very restricted due to low manpower.
