Bug 484253 - [HTML][assist] Add attribute values content assist
Summary: [HTML][assist] Add attribute values content assist
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: JS Tools (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 11.0   Edit
Assignee: Carolyn MacLeod CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-11 14:26 EST by Carolyn MacLeod CLA
Modified: 2016-01-26 09:14 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2015-12-11 14:26:21 EST 
The code in htmlContentAssist.js for proposing attribute values currently looks like this:
		getValuesForAttribute: function(node, params) {
			//TODO compute the options for the given attribute
			return [];	
		},

Need to flesh this out.

This may need to be done in 2 parts:
1) I already have all of the value data for ARIA attributes, so I can write getValuesForAttribute and plug in the ARIA data.

2) I do not have the value data for HTML attributes, so this needs to come from somewhere (perhaps scrape it from the HTML spec, or from MDN, etc). So I may need to open a new bug for part 2. For now, I hope to code both parts together.
Comment 1 Carolyn MacLeod CLA 2016-01-26 09:05:13 EST 
Fixed part 1 (ARIA attribute values) and for part 2, fixed all HTML attribute values that we already had data for, and added data for <input type=...> values (because there's 22 of them, and having input type attribute values plus their doc available is useful). Also added 5 unit tests.

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=ac9e1167018c153e6a30d057d26568f52c7e1ecb

However I will need to open a new bug to track the rest of part 2. We need to get more HTML attribute value data in there.
Comment 2 Carolyn MacLeod CLA 2016-01-26 09:14:14 EST 
Opened Bug 486567 - Finish getting HTML attribute value data from spec

Closing this bug as the attribute values content assist feature is now in.