Bug 484164 - [otdre] fix regressions in OTJLD test suite
Summary: [otdre] fix regressions in OTJLD test suite
Status: CLOSED MOVED
Alias: None
Product: Objectteams
Classification: Tools
Component: OTJ (show other bugs)
Version: 2.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 459269 469757 469759 469760 469761 469762 469767 469768 469769 469770 469771 469772 469773 469774 490231
Blocks:
  Show dependency tree
 
Reported: 2015-12-10 19:20 EST by Stephan Herrmann CLA
Modified: 2023-07-21 15:48 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2015-12-10 19:20:32 EST
Umbrella ticket for regressions in the OTJLD test suite when run under OTDRE.
Comment 1 Stephan Herrmann CLA 2016-05-24 16:52:18 EDT
Status as per 2.5 RC2:

down to 13 failures in OTJLD test suite:

test4513_basecallSuperAccess4
test4513_basecallSuperAccess5
test5215_explicitActivationForAllThreads1a
test5218_inheritableTeamActivation1
test5316_implicitActivationAnnotation1
test531b_callinInvocationInTeamMethod
test914_bindingPredicate22
testB11_ju1
testB11_sh42
testB11_sh53
testX11_bindingInheritance12
testX11_bindingInheritance13
testX11_bindingInheritance14

To be continued during 2.6
Comment 2 Stephan Herrmann CLA 2016-10-29 18:13:51 EDT
At 2.6 M3 (12 failures):

test1126_nestingAndLayering2
test4513_basecallSuperAccess4
test4513_basecallSuperAccess5
test5215_explicitActivationForAllThreads1a
test531b_callinInvocationInTeamMethod
test914_bindingPredicate22
testB11_ju1
testB11_sh42
testB11_sh53
testX11_bindingInheritance12
testX11_bindingInheritance13
testX11_bindingInheritance14

Diff:
+ test1126_nestingAndLayering2 

#  SIGSEGV (0xb) at pc=0xb6dcaab4, pid=19611, tid=0x6327eb40
#
# JRE version: Java(TM) SE Runtime Environment (8.0_92-b14) (build 1.8.0_92-b14)
# Java VM: Java HotSpot(TM) Server VM (25.92-b14 mixed mode linux-x86 )
# Problematic frame:
# V  [libjvm.so+0x62eab4]  klassItable::initialize_itable_for_interface(int, KlassHandle, bool, Thread*)+0x24

- test5218_inheritableTeamActivation1    (fixed by bug 469761)
- test5316_implicitActivationAnnotation1 (also bug 469761?)
Comment 3 Stephan Herrmann CLA 2018-01-28 13:48:12 EST
In Photon M5 we have a couple more bogus type errors:

BaseClassVisibility.test242_inaccessibleBaseClass17
  The method added(List<T>, T) in the type Team242ibc17.RoleClass is not applicable for the arguments (List<T242ibc17.InnerBase>, InnerRole<@tthis[RoleClass]>)

LiftingAndLowering.test2212_arrayLoweringToBaseclass9
  Type mismatch: cannot convert from R<@tthis[Team2214altb9]>[] to T2214altb9[]
Comment 4 Stephan Herrmann CLA 2018-02-10 15:56:52 EST
Our ASTRewriteFlattenerTest has two regressions in maintenance/OTDT_2.6.x, which are caused by JDT's bug 527351 (fixed in Photon M4):
- testNewFullyCuCreation
- testNewCuCreation
both reporting "CompilationUnit has no property module".
Comment 5 Stephan Herrmann CLA 2018-02-11 07:46:23 EST
(In reply to Stephan Herrmann from comment #3)
> In Photon M5 we have a couple more bogus type errors:
> 
> BaseClassVisibility.test242_inaccessibleBaseClass17
>   The method added(List<T>, T) in the type Team242ibc17.RoleClass is not
> applicable for the arguments (List<T242ibc17.InnerBase>,
> InnerRole<@tthis[RoleClass]>)
> 
> LiftingAndLowering.test2212_arrayLoweringToBaseclass9
>   Type mismatch: cannot convert from R<@tthis[Team2214altb9]>[] to
> T2214altb9[]

Resolved for 2.7M6 via http://git.eclipse.org/c/objectteams/org.eclipse.objectteams.git/commit/?id=5bc28dc89944fcd807a0d9817669bf7b37783d52
Comment 6 Stephan Herrmann CLA 2018-02-11 07:48:13 EST
Status as of build #229 (master towards 2.7M6):

test4513_basecallSuperAccess4
test4513_basecallSuperAccess5
test5215_explicitActivationForAllThreads1a
test531b_callinInvocationInTeamMethod
testB11_ju1
testB11_sh42
testB11_sh53
testX11_bindingInheritance12
testX11_bindingInheritance13
testX11_bindingInheritance14

plus intermittently:
ImplicitTeamActivation.test5317_concurrentActivation1

And no other regressions in OT suites.
Comment 7 Stephan Herrmann CLA 2018-02-13 18:41:14 EST
Taking stock as of 2.6.2 RC1 (for Oxygen.3):

OTJLD tests the same 10 failures as comment 6.

ASTRewriteFlattenerTest.{testNewFullyCuCreation,testNewCuCreation}
 => bug 527351 (fixed only in master)

Other OT tests to be checked:
org.eclipse.objectteams.otdt.test.builder.MultipleCallinsWarningTest.testMultipleCallinsDifferentTeams2
org.eclipse.objectteams.otdt.ui.tests.core.OrganizeImportsTest.testCalloutToStatic
org.eclipse.objectteams.otdt.ui.tests.core.CodeCompletionTest.testCreateRoleConstructor
Comment 8 Stephan Herrmann CLA 2018-06-05 16:19:39 EDT
Bulk move to 2.8
Comment 9 Stephan Herrmann CLA 2018-06-06 18:45:57 EDT
In build https://hudson.eclipse.org/objectteams/job/buildAndTest/271 (2.7 RC2) we had the exact 10 known failures in OTJLD suites

plus

- some intermittent failures in ImplicitTeamActivation.{test5316_implicitActivationAnnotation2,test5310_callinBindingWithFinalTeam1,test5317_concurrentActivation1,test531a_callinInvocationInTeamMethod}, each at one compliance level only.

- OTEquinoxBuilderTests.testAccumulatedBases1
  OTRE vs. OTDRE issue with class file version 52,
  caused by recent change in AbstractJavaModelTest.setUpJavaProject
  => fixable in the test

- OrganizeImportsTest.testCalloutToStatic
  bogus import static generated

- RenameVirtualMethodInClassTests
  7 tests constantly fail on hudson, but pass locally 

Looks quite good for 2.7 but needs to be continued in 2.8.
Comment 10 Stephan Herrmann CLA 2018-07-30 16:31:51 EDT
(In reply to Stephan Herrmann from comment #9)
> In build https://hudson.eclipse.org/objectteams/job/buildAndTest/271 (2.7
> RC2) we had the exact 10 known failures in OTJLD suites
> 
> plus
> 
> - some intermittent failures in
> ImplicitTeamActivation.{test5316_implicitActivationAnnotation2,
> test5310_callinBindingWithFinalTeam1,test5317_concurrentActivation1,
> test531a_callinInvocationInTeamMethod}, each at one compliance level only.
> 
> - OTEquinoxBuilderTests.testAccumulatedBases1
>   OTRE vs. OTDRE issue with class file version 52,
>   caused by recent change in AbstractJavaModelTest.setUpJavaProject
>   => fixable in the test
> 
> - OrganizeImportsTest.testCalloutToStatic
>   bogus import static generated
> 
> - RenameVirtualMethodInClassTests
>   7 tests constantly fail on hudson, but pass locally 

That was bug 537467 (it seems that locally I didn't have a sufficiently recent version of JDT/UI)
Comment 11 Stephan Herrmann CLA 2020-03-06 16:59:36 EST
bulk move to 2.8.1
Comment 12 Stephan Herrmann CLA 2021-03-07 06:56:12 EST
I disabled the 10 failing tests via https://git.eclipse.org/c/objectteams/org.eclipse.objectteams.git/commit/?h=OI2JIRO&id=3f679349b3ab6df43f8b1d05f935bd491b9396a2 

To identify our subjects search for calls to AbstractOTJLDTest.isKnownFailure()
Comment 13 Stephan Herrmann CLA 2023-07-20 07:42:15 EDT
Bulk move to 2.8.3
Comment 14 Stephan Herrmann CLA 2023-07-21 15:48:15 EDT
Moved to https://gitlab.eclipse.org/eclipse/objectteams/objectteams/-/issues/1