Bug 469761 - [otdre] implement inheritable team activation
Summary: [otdre] implement inheritable team activation
Status: RESOLVED FIXED
Alias: None
Product: Objectteams
Classification: Tools
Component: OTJ (show other bugs)
Version: 2.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2.5.2   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 484164
  Show dependency tree
 
Reported: 2015-06-09 14:04 EDT by Stephan Herrmann CLA
Modified: 2016-11-22 18:38 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2015-06-09 14:04:59 EDT 
Test org.eclipse.objectteams.otdt.tests.otjld.teamactivation.ExplicitTeamActivation.test5218_inheritableTeamActivation1() still fails under OTDRE:

t.setInheritableActivation(true) has no effect
Comment 1 Stephan Herrmann CLA 2016-10-06 13:08:17 EDT 
Analysis: _OT$creationThread was never set in, because we were overriding the wrong hook. With no creation thread, TeamThreadManager.newThreadStarted() cannot detect if the parent thread has the team activated.
Comment 2 Stephan Herrmann CLA 2016-10-06 13:46:12 EDT 
(In reply to Stephan Herrmann from comment #1)
> Analysis: _OT$creationThread was never set in,

insert: in *constructors of Thread / Runnable*.

> because we were overriding the wrong hook. 

Viz. the AdviceAdapter in AddThreadNotificationAdapter.visitMethod() must override visitMethodInsn() not visitConstructor().


Fixed in commit 0f949b15db1190dca0d6644f8deab2d8cd482955

Released for 2.6 M3
Comment 3 Stephan Herrmann CLA 2016-11-22 14:14:01 EST 
Cherry picked for 2.5.2 as commit 3dffdcf7358c5d5884d62f264640d7e7fdaeb533