Bug 483805 - Editor rulers paint their artifacts even if they are invisible
Summary: Editor rulers paint their artifacts even if they are invisible
Status: CLOSED DUPLICATE of bug 467499
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 4.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.6 M6   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2015-12-07 09:48 EST by Snjezana Peco CLA
Modified: 2016-03-14 11:13 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Snjezana Peco CLA 2015-12-07 09:48:55 EST 
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=467499#c20
Comment 1 Eclipse Genie CLA 2015-12-07 10:17:37 EST 
New Gerrit change created: https://git.eclipse.org/r/62114
Comment 2 Dani Megert CLA 2015-12-07 10:19:49 EST 
Do you have numbers that show how much we gain with this?
Comment 3 Snjezana Peco CLA 2015-12-07 10:28:13 EST 
(In reply to Dani Megert from comment #2)
> Do you have numbers that show how much we gain with this?

It depends on the number of annotations in a project(s), the number of activated editors... 
In my opinion, performance improvement can be significant if a user has big projects and a lot of opened editors.
Comment 4 Dani Megert CLA 2015-12-08 10:17:46 EST 
(In reply to Snjezana Peco from comment #3)
> (In reply to Dani Megert from comment #2)
> > Do you have numbers that show how much we gain with this?
> 
> It depends on the number of annotations in a project(s), the number of
> activated editors... 
> In my opinion, performance improvement can be significant if a user has big
> projects and a lot of opened editors.

Please provide a test case that allows to see it.
Comment 5 Snjezana Peco CLA 2015-12-08 13:23:36 EST 
(In reply to Dani Megert from comment #4)
> 
> Please provide a test case that allows to see it.

You can try the test case described in https://bugs.eclipse.org/bugs/show_bug.cgi?id=467499#c8
You would need to add a breakpoint to AnnotationRulerColumn.doubleBufferPaint and debug Eclipse PDE.
Comment 6 Andrey Loskutov CLA 2016-03-05 18:19:17 EST 
I confirm the steps & I think the patch makes lot of sense. I wonder it was unnoticed before.

Steps to reproduce (from bug 467499 comment 8):

- create a Java project
- create a class A.java with some errors  and/or warnings
- create a class B.java without errors/warnings
- open/activate A.java
- open B.java
- rebuild the project

You will see that the annotations related to A.java are shown in the current editor (B.java). If you resize Eclipse window and rebuild the project, the annotations can appear in an unexpected place (within the editor or completely out of the editor area).

For a non-GTK3 case (where the wrong artifacts aren't shown) the benefit of the patch is that rulers with annotations aren't repainted for *all* opened editors on build, but only for the visible, means: better UI performance in case of many open editors.

I'm s still playing with the patch https://git.eclipse.org/r/62114/
Comment 7 Dani Megert CLA 2016-03-14 11:13:10 EDT 

*** This bug has been marked as a duplicate of bug 467499 ***