Bug 483419 - Eclipse text editors mess up the height of all lines if a single large character is discovered
Summary: Eclipse text editors mess up the height of all lines if a single large charac...
Status: CLOSED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.5   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-SWT-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2015-12-01 19:18 EST by Stefan Xenos CLA
Modified: 2018-12-14 12:38 EST (History)
4 users (show)

See Also:


Attachments
Screenshot demonstrating the bug (43.21 KB, image/png)
2015-12-01 20:38 EST, Stefan Xenos CLA
no flags Details
Screenshot of the same file, without the line containing the problem character (38.34 KB, image/png)
2015-12-01 20:38 EST, Stefan Xenos CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Xenos CLA 2015-12-01 19:18:46 EST
To reproduce:
- Select a monisized font (like Inconsolata)
- Create a file that is mostly ASCII, but contains the characters "ಠ-ಠ" somewhere in it.
- Open it in any Eclipse text editor (reproducible in plain text and Java editors).

Observed:
- Whitespace is added to all lines in the file, making them all as tall as the tall character.

Expected:
- Either whitespace is only added to the line containing the large character OR the line containing the large character is truncated vertically to match the other "monospaced" characters. In either case, lines which do not contain the unusually large character should not have any additional whitespace.
Comment 1 David Williams CLA 2015-12-01 20:22:24 EST
I don't see it. I assume you mean character \u0CA0? 
On my system, it appears no larger that 'M' or '0'. 
And none of them increase line height -- that I can see. 

I am on Ubuntu Linux and got the Inconsolata font from their repository. 

Perhaps you could be more specific about your system? And where you got your Inconsolata font? 

Plus, you might attach some screen captures that demonstrates the effect, to make sure I am looking at the right thing. 

All that said, I am just looking because I was curious. I'm not sure much can be done to accommodate subtle details of a rasterized font. Guess it depends on how it was hinted, and that might depend on the exact version of the font you have? 
Or, perhaps you could demonstrate the effect happens on more than one monospaced font?
Comment 2 Stefan Xenos CLA 2015-12-01 20:38:15 EST
Created attachment 258404 [details]
Screenshot demonstrating the bug
Comment 3 Stefan Xenos CLA 2015-12-01 20:38:39 EST
Created attachment 258405 [details]
Screenshot of the same file, without the line containing the problem character
Comment 4 Stefan Xenos CLA 2015-12-01 20:39:33 EST
About my system: I'm running the GTK2 version of Eclipse 4.5 on Ubuntu.
Comment 5 Stefan Xenos CLA 2015-12-01 20:40:55 EST
Compare the two attached screenshots, and notice that the line spacing is larger in the text editor containing the problem character, for all lines.

The text in comment 0 demonstrates the bug -- I reproduced it by copying-and-pasting the comment.
Comment 6 David Williams CLA 2015-12-01 21:13:39 EST
Thanks for the screen shots. And, I still can't reproduce. Was sure to use a fresh Mars.1 install. Tried with GTK2 and 3 (if 3 works at all on my system?), Ubuntu 12.10 (but highly customized). 

My Inconsolata font version is 001.010.4 (precise) according to Synaptic. 

Have you tried other monospaced fonts? (I did, they all looked similar in term of line height). 

Do you have any form of "scaling" turned on? (I do not: 1.0 at system level). 

I'll move this over to SWT, perhaps they know more about what to ask.
Comment 7 David Williams CLA 2015-12-01 21:14:56 EST
SWT, assuming this is your issue if there is an Eclipse issue at all? (i.e. you draw Styled Text, and I assume that's independent of anything the editors might set?) 

Thanks,
Comment 8 Eric Williams CLA 2018-11-30 11:06:13 EST
Ping, is this still reproducible?
Comment 9 Eric Williams CLA 2018-12-14 12:38:37 EST
Closing this ticket now as there has been no response in awhile. Please reopen it if you can reproduce the issue on GTK3.22/24 using SWT 4.10.