Bug 482018 - [GTK] Implement APIs for multi-touch events and gestures
Summary: [GTK] Implement APIs for multi-touch events and gestures
Status: CLOSED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Ian Pun CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on: 510538
Blocks:
  Show dependency tree
 
Reported: 2015-11-12 09:38 EST by Markus Keller CLA
Modified: 2021-04-30 10:04 EDT (History)
8 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2015-11-12 09:38:51 EST 
Bug 279884 added APIs for multi-touch events and gestures, and implementations on Windows and Mac.

Implementation on GTK is still missing. Added a warning to the APIs: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=638f934232d5f4888b370b7f5d90cae4c955117c
Comment 1 Eclipse Genie CLA 2017-01-18 10:48:01 EST 
New Gerrit change created: https://git.eclipse.org/r/88998
Comment 2 Ian Pun CLA 2017-01-27 16:46:52 EST 
Tested this on Fedora 25 with a T460s with a touchscreen, working in both wayland/X11 for touch screen, and only in Wayland for touchpad gestures
Comment 3 Alexander Kurtakov CLA 2017-01-30 09:39:18 EST 
Ian, do you consider this ready for review?
Comment 4 Ian Pun CLA 2017-02-06 09:45:35 EST 
(In reply to Alexander Kurtakov from comment #3)
> Ian, do you consider this ready for review?

Hey Alex,

Yes the patch is ready for review
Comment 6 Dani Megert CLA 2017-02-07 02:39:03 EST 
(In reply to Eclipse Genie from comment #5)
> Gerrit change https://git.eclipse.org/r/88998 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=792560288388dee83bbcfaf3e4dcbee3b61c8044
> 

#setPanGesture needs to be used or removed. Currently we get warnings in our official build:

http://download.eclipse.org/eclipse/downloads/drops4/I20170206-2000/testResults.php
Comment 7 Eclipse Genie CLA 2017-02-07 03:07:54 EST 
New Gerrit change created: https://git.eclipse.org/r/90491
Comment 9 Alexander Kurtakov CLA 2017-02-07 03:15:04 EST 
Commented out setPanGesture.
Ian, please describe what has to be decided for setPanGesture so we can get this finished.
Comment 10 Alexander Kurtakov CLA 2017-02-07 03:24:59 EST 
(In reply to Alexander Kurtakov from comment #9)
> Commented out setPanGesture.
> Ian, please describe what has to be decided for setPanGesture so we can get
> this finished.

Further thinking - gtk doc says GTK_ORIENTATION_HORIZONTAL is default so maybe go with it?
Comment 11 Ian Pun CLA 2017-05-30 15:30:42 EDT 
Because PanGesture does not have any method calls to get the correct offset (https://developer.gnome.org/gtk3/stable/GtkGesturePan.html) , we are reliant on the parameter that is being passed in through the "pan" signal. This will be implemented after Leo finishes his work on bug 510538.
Comment 12 Ian Pun CLA 2017-12-27 14:07:26 EST 
@Leo, could I get the status of the pan gesture work?
Comment 13 Eric Williams CLA 2019-02-15 15:30:49 EST 
Closing this one as it blocks nothing and the dependent bug 510538 is valid for other uses, not just pan gestures.