Community
Participate
Working Groups
The following import is used. import org.eclipse.ui.views.properties.tabbed.TabbedPropertySheetWidgetFactory; Then the following object is created. TabbedPropertySheetWidgetFactory widgetFactory = new TabbedPropertySheetWidgetFactory(); Finally, the following call always returns white (Color object), while Eclipse is set to dark theme under Window -> Preferences -> General -> Appearance -> Theme: Dark. widgetFactory.getColors().getBackground();
Moving to platform ui for comments.
The underlying factory uses the UI Forms FormColors class to manage colors, which initializes itself using the system colours (i.e., Display#getSystemColor()) and not CSS. I don't think it makes sense to have UI Forms know about our CSS implementation. But our CSS can't change the colours returned by Display#getSystemColor(). We could establish a convention of having a look-aside colour mapping on the Display instance. FormColors already has a getSystemColor() and we could modify it (and change everything to use it) to something like: public RGB getSystemColor(int code) { Map<Integer,Color> lookaside = (Map)getDisplay().getData("org.eclipse.e4.ui.css.swt.SystemColorsLookaside"); if(lookaside != null && lookaside.containsKey(code)) { return lookaside.get(code).getRGB(); } return getDisplay().getSystemColor(code).getRGB(); }
Mass move to 4.7 as M7 is approaching. Please move back in case you are planning to fix it for Neon.
Created attachment 263008 [details] test project to test the current background and foreground system colors. (In reply to Brian de Alwis from comment #2) > > We could establish a convention of having a look-aside colour mapping on the > Display instance. FormColors already has a getSystemColor() and we could > modify it (and change everything to use it) to something like: > > public RGB getSystemColor(int code) { > Map<Integer,Color> lookaside = > (Map)getDisplay().getData("org.eclipse.e4.ui.css.swt.SystemColorsLookaside"); > if(lookaside != null && lookaside.containsKey(code)) { > return lookaside.get(code).getRGB(); > } > return getDisplay().getSystemColor(code).getRGB(); > } That's a brilliant Idea! I propose the following: - add the Map<Integer, Color>, in the User Preferences - each time the user changes the theme, store in the map both the Background and the Foreground color for the selected theme. Attached you find a plug-in project with a view to test the resolution.. Show View: Bug Test > System Colors. You'll see a UI like this: http://i.imgur.com/SeMV9Po.png
I've one extra question: Do you think we can reuse the colors defined in the CSS for Background and Foreground ? As example, see: http://i.imgur.com/D7UHDUq.png. We see default_mac.css, and default_win.css importing e4_basestyle.css; where we see several colors are defined in CSS. So, I'm thinking to reuse some of the colors defined in the CSS, and put them as BG and FG in eclipse, using the LookAside mechanism suggested by Brian. What do you think about this? Which of the colors defined in css would you use to better represent BackGround and ForeGround colors in Eclipse?
Are there any updates of any kind for this issue, or any plans to fix?
