Bug 481941 - deploy eclipse parent should be triggered by "changes from SCM"
Summary: deploy eclipse parent should be triggered by "changes from SCM"
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 4.6 M4   Edit
Assignee: Mickael Istria CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2015-11-11 11:44 EST by David Williams CLA
Modified: 2015-11-16 03:50 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2015-11-11 11:44:00 EST
I am opening this enhancement due to comments made in bug 481904. 

Currently, the "deploy Eclipse parent" job, runs once a day. 

I think originally, it ran every 10 minutes, as a cronjob ("run periodically"),  but that seemed wasteful and I asked for it to be changed. Especially wasteful since it uses "wget" to get files from the repository and "does its thing" -- partially with bash scripts. It was explained to me that "if there were no changes" no harm is done since the maven repository could tell there were no differences, so did not literally store a new artifact every 10 minutes. But still ... a little wasteful. 

But, there are times when committers do not want to wait a day, to get some changes. Currently, they have to know to go and "manually" run the job by pressing the "schedule build button".  That is not a bad solution, but it also seems we could make better use of Git and Hudson automation. 

I see no reason not to make a shallow clone of the repository, and then "check SCM" every 10 or 15 minutes, and THEN if a change is detected, go ahead with the rest of the "deploy" steps. Perhaps then, also, the scripts would work off of the clone version of the repository, instead of using wget vis CGit, since I've found that to be slightly unreliable. (That is, sometimes changes made to Git, are not immediately "visible" with CGit.
Comment 1 David Williams CLA 2015-11-11 11:44:59 EST
I have to plans to work on this soon, so will mark as "help wanted". 

I mostly just didn't want to lose track of some small improvement that could be made.
Comment 2 Mickael Istria CLA 2015-11-13 10:08:01 EST
@David: I can try to take care of it if you want.
Comment 3 David Williams CLA 2015-11-13 10:51:52 EST
(In reply to Mickael Istria from comment #2)
> @David: I can try to take care of it if you want.

Sounds good to me. Let's see if Mikael can review proposed changes since he is most familiar with "deploying to Eclipse". 

Thanks,
Comment 4 Lars Vogel CLA 2015-11-13 11:21:27 EST
(In reply to David Williams from comment #3)
> (In reply to Mickael Istria from comment #2)
> > @David: I can try to take care of it if you want.
> 
> Sounds good to me. Let's see if Mikael can review proposed changes since he
> is most familiar with "deploying to Eclipse". 
> 
> Thanks,

Good idea, let Mikael review Mikael change. ;-)
Comment 5 Mickael Istria CLA 2015-11-16 03:50:33 EST
The job has been configured to
* Use Git fetch instead of wget to retrieve parent, with filters on the folder to watch for changes.
* Use "Poll SCM @hourly" instead of "Build periodically @daily"

This seems to work fine so far. But in case you notice/anticipate anything wrong, feel free to reopen.