481470 – Change all remaining instances of element.role = ...; to element.setAttribute("role", ...);

Bug 481470 - Change all remaining instances of element.role = ...; to element.setAttribute("role", ...);

Summary: Change all remaining instances of element.role = ...; to element.setAttribute...

Status:	RESOLVED FIXED

Alias:	None

Product:	Orion (Archived)
Classification:	ECD
Component:	Client (show other bugs)
Version:	unspecified
Hardware:	PC Windows 7

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Carolyn MacLeod
QA Contact:

URL:
Whiteboard:
Keywords:	accessibility

Depends on:
Blocks:

Reported:	2015-11-05 01:04 EST by Carolyn MacLeod
Modified:	2015-11-09 13:57 EST (History)
CC List:	1 user (show)

See Also:	Gerrit Change Git Commit Gerrit Change Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Carolyn MacLeod

2015-11-05 01:04:31 EST

See bug 481468 comment 3 for explanation.

Comment 1 Carolyn MacLeod

2015-11-05 01:10:18 EST

Also searched for element.aria-... to see if any other aria- attributes were being set using dot notation. All places where aria- attributes are being set are using element.setAttribute("aria-...", "...");
So we don't need to change these; only the ones for element.role = ...;

Comment 2 Carolyn MacLeod

2015-11-05 01:41:58 EST

Also found one instance of element["aria-..."] = ...;
This won't work for aria- attributes either. Need to use setAttribute().

Comment 3 Eclipse Genie

2015-11-05 01:44:30 EST

New Gerrit change created: https://git.eclipse.org/r/59706

Comment 4 Eclipse Genie

2015-11-06 14:34:46 EST

Gerrit change https://git.eclipse.org/r/59706 was merged to [master].
Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=895561e96347027315b316d76e639648c3ea27a9

Comment 5 Silenio Quarti

2015-11-06 15:14:52 EST

I have reverted this change because there is an exception opening the Settings page (setAttribute is not a function).

Comment 6 Eclipse Genie

2015-11-07 16:46:59 EST

New Gerrit change created: https://git.eclipse.org/r/59901

Comment 7 Eclipse Genie

2015-11-08 14:35:36 EST

New Gerrit change created: https://git.eclipse.org/r/59910

Comment 8 Eclipse Genie

2015-11-09 13:52:34 EST

Gerrit change https://git.eclipse.org/r/59910 was merged to [master].
Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=51d38bfeacfcf4627009a2940128c4861e8bb60e

Comment 9 Carolyn MacLeod

2015-11-09 13:57:22 EST

Fixed by commit in comment 8.