Bug 481468 - User Menu items need role "menuitem" to have complete semantics
Summary: User Menu items need role "menuitem" to have complete semantics
Status: RESOLVED FIXED
Alias: None
Product: Orion (Archived)
Classification: ECD
Component: Client (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Carolyn MacLeod CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2015-11-05 00:25 EST by Carolyn MacLeod CLA
Modified: 2015-11-06 15:23 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carolyn MacLeod CLA 2015-11-05 00:25:51 EST 
The User Menu (aka Options menu - the one with the person icon) has a role of "menu", but the elements it contains do not have role "menuitem".
Assistive Technology can't understand what this is because the semantic structure of the menu is incomplete.
Comment 1 Carolyn MacLeod CLA 2015-11-05 00:35:20 EST 
There are 2 different types of menu item in the User Menu:
1) link menu items, which are created in UserMenu.js
2) and span (aka 'text') menu items, which are created in dropdown.js.

It turns out that the code did attempt to set the role to "menuitem" in both cases, but the code was:
  element.role = "menuitem";

However, that unfortunately doesn't work (yet) because "role" is a non-standard attribute. So the code needs to be:
  element.setAttribute("role", "menuitem");
Comment 2 Eclipse Genie CLA 2015-11-05 00:46:03 EST 
New Gerrit change created: https://git.eclipse.org/r/59705
Comment 3 Carolyn MacLeod CLA 2015-11-05 01:06:30 EST 
A search for .role shows that there are 6 other places where element.role is used.
These need to be changed to element.setAttributes("role", "the-role");
Opened separate bug 481470 to fix the other places.
Comment 5 Carolyn MacLeod CLA 2015-11-06 15:23:48 EST 
Fixed.