480917 – Use PHP or Php in all types/methods

Bug 480917 - Use PHP or Php in all types/methods

Summary: Use PHP or Php in all types/methods

Status:	RESOLVED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	PDT (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	---
Assignee:	PHP Core
QA Contact:

URL:
Whiteboard:
Keywords:	api

Depends on:
Blocks:

Reported:	2015-10-28 15:28 EDT by Dawid Pakula
Modified:	2020-05-14 10:17 EDT (History)
CC List:	3 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Gerrit Change Git Commit Git Commit Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Dawid Pakula

2015-10-28 15:28:41 EDT

We have a mess with PHP keywords usage. Some class/methods use "PHP" some "Php". It's really annoying.

I think we should decide which version is better, and fix this in whole repository where it's possible.

I prefer PHP. What you think?

Comment 1 Michal Niewrzal

2015-10-28 17:50:00 EDT

+1 for PHP

Comment 2 Dawid Pakula

2016-04-26 16:38:09 EDT

The others?

This change will unpleasant from adopter perspective ;)

Comment 3 Thierry BLIND

2016-04-26 16:45:49 EDT

+1 for PHP :)

Comment 4 Dawid Pakula

2016-05-28 16:02:45 EDT

It's too late. Problem similar to PHPVersion... 

Remove target version for now.

Comment 5 Kaloyan Raev

2017-05-04 10:29:08 EDT

Dawid, do you plan to work on this? I think now is the right moment :-)

Comment 6 Thierry BLIND

2017-05-04 17:30:27 EDT

(In reply to Kaloyan Raev from comment #5)
> Dawid, do you plan to work on this? I think now is the right moment :-)

+1 ;)
I started with https://git.eclipse.org/r/#/c/94907/ but better do it everywhere :)

Comment 7 Dawid Pakula

2017-05-05 01:44:04 EDT

I'll look at it over the weekend.

Comment 8 Eclipse Genie

2017-05-09 07:22:59 EDT

New Gerrit change created: https://git.eclipse.org/r/96638

Comment 9 Eclipse Genie

2017-05-09 17:59:36 EDT

Gerrit change https://git.eclipse.org/r/96638 was merged to [master].
Commit: http://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=73522b79e503710cf43dffd0472c6d72501089c5

Comment 10 Eclipse Genie

2017-05-09 18:10:30 EDT

New Gerrit change created: https://git.eclipse.org/r/96690

Comment 11 Eclipse Genie

2017-05-09 18:30:23 EDT

Gerrit change https://git.eclipse.org/r/96690 was merged to [master].
Commit: http://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=d8ab4527aa586e0fcd511299587f051208cf1d89

Comment 12 Eclipse Genie

2017-05-09 22:57:02 EDT

New Gerrit change created: https://git.eclipse.org/r/96697

Comment 13 Eclipse Genie

2017-05-10 05:06:22 EDT

New Gerrit change created: https://git.eclipse.org/r/96713

Comment 14 Eclipse Genie

2017-05-10 06:47:04 EDT

Gerrit change https://git.eclipse.org/r/96697 was merged to [master].
Commit: http://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=fdba8310e7b9c1b373307676e7192df85d626ec2

Comment 15 Eclipse Genie

2017-05-10 07:13:13 EDT

Gerrit change https://git.eclipse.org/r/96713 was merged to [master].
Commit: http://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=ed3bdc5d0d4e45b7fbfb171e8555917f22b9590c

Comment 16 Eclipse Genie

2017-05-10 12:05:48 EDT

New Gerrit change created: https://git.eclipse.org/r/96755

Comment 17 Eclipse Genie

2017-05-10 15:31:56 EDT

Gerrit change https://git.eclipse.org/r/96755 was merged to [master].
Commit: http://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=5b4ca7de8f71c1ded77c1778ad23162bdef79269

Comment 18 Eclipse Genie

2017-05-13 08:01:50 EDT

New Gerrit change created: https://git.eclipse.org/r/97013

Comment 19 Eclipse Genie

2017-05-13 08:22:25 EDT

Gerrit change https://git.eclipse.org/r/97013 was merged to [master].
Commit: http://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=1ce1c6d1ff3441f45fe131d8ff580e61c0a21083

Comment 20 Eclipse Genie

2017-05-17 05:33:43 EDT

New Gerrit change created: https://git.eclipse.org/r/97312

Comment 21 Eclipse Genie

2017-05-17 11:10:05 EDT

Gerrit change https://git.eclipse.org/r/97312 was merged to [master].
Commit: http://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=ed415d5542431e222fc8df5acd465b5d04944112

Comment 22 Dawid Pakula

2017-05-17 11:10:30 EDT

Looks like we done here ;)