Bug 480053 - Views left open for uninstalled plug-ins display error message with Exceptions
Summary: Views left open for uninstalled plug-ins display error message with Exceptions
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.15   Edit
Hardware: PC Windows 10
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-17 16:39 EDT by Glen A. CLA
Modified: 2020-05-04 12:15 EDT (History)
3 users (show)

See Also:


Attachments
what the error looks like to the user (with Details pressed) (48.96 KB, image/png)
2020-05-04 07:22 EDT, Jonah Graham CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Glen A. CLA 2015-10-17 16:39:42 EDT
I tried to uninstall the plug-in on a brand new installation of Eclipse (Mars.1) with about 9 other plug-ins, and I now see:

1. Plug-in JARs still exist. (http://snag.gy/mvEgR.jpg)
2. Views missing in the "Show View" window. (http://snag.gy/vPJ11.jpg)
3. And this entry in the log:

!ENTRY org.eclipse.core.runtime 4 0 2015-10-17 22:08:59.197
!MESSAGE Invalid input url:platform:/plugin/org.eclipse.tm.terminal.view.ui/icons/eview16/terminal_view.gif
!STACK 0
java.io.IOException: Unable to resolve plug-in "platform:/plugin/org.eclipse.tm.terminal.view.ui/icons/eview16/terminal_view.gif".

(stack @ http://pastie.org/private/hzejiogri7fxoqiusq52lq)

Creating a new workspace fixes the "Show View" window, but this really shouldn't happen and the plug-ins should surely have been removed?
Comment 1 Martin Oberhuber CLA 2015-10-18 07:34:28 EDT
Please help us reproduce the issue:

- Which Mars.1 did you start from ? A package or the core SDK ?
  Installed as a single archive or used the eclipse-installer ?
- How did you get the Terminal plugin into your install ?
- How did you try to uninstall (which UI gestures) ?
- Your host OS is indicated as Windows 10, can you confirm ?

You also wrote:
> 1. Plug-in JARs still exist

This might be normal behavior from Eclipse/p2 . Uninstalling a plug-in does not necessarily remove it from disk - there is a "garbage collection" which may do that at a later time. If you could "Help > About : Installation Details : Configuration", copy-and paste the config to a file and attach here, it might help diagnosis.


You also wrote:
> 2. Creating a new workspace fixes the "Show View" window, 

This would indicate that Platform/UI had left the "Show View" in its UI model, although the remnants of Terminal are all properly removed. This might indicate a defect in Platform/UI, and not in the Terminal.

You also wrote:
> 3. !ENTRY org.eclipse.core.runtime 4 0 2015-10-17 22:08:59.197
!MESSAGE Invalid input url:platform:/plugin/org.eclipse.tm.terminal.view.ui/icons/eview16/terminal_view.gif

In case the Terminal View had been open in your workspace at the time you uninstalled it, this might be normal behavior: Platform/UI tries to restore your perspective on restart, but the plug-in implementing the view (and its icon) is no longer there.
Comment 2 Glen A. CLA 2015-10-18 08:34:33 EDT
> - Which Mars.1 did you start from ? A package or the core SDK ?
>   Installed as a single archive or used the eclipse-installer ?

The Platform Runtime Binary (eclipse-platform-4.5.1-win32-x86_64.zip).

I also installed these plug-ins:

* PDT from main repo (Mars - http://download.eclipse.org/releases/mars).
* EGit from http://download.eclipse.org/egit/updates
* AnyEdit tools from http://andrei.gmxhome.de/eclipse/
* YEdit from http://dadacoalition.org/yedit
* Composer Eclipse Plugin from http://p2-dev.pdt-extensions.org/
* Markdown Editor plug-in from http://www.winterwell.com/software/updatesite/
* EditorConfig Eclipse from https://editorconfig-eclipse.github.io/repository
* Eclipse Color Theme from http://eclipse-color-theme.github.io/update/
* Doctrine plug-in from http://p2.pdt-extensions.org/

> - How did you get the Terminal plugin into your install ?

I used the update site http://download.eclipse.org/tm/terminal/marketplace

> - How did you try to uninstall (which UI gestures) ?

Help > Installation Details > (select plug-in) > (click Uninstall...)

> - Your host OS is indicated as Windows 10, can you confirm ?

Yes, Win10.

> If you could "Help > About : Installation Details : Configuration", copy-and paste the config to a file and attach here, it might help diagnosis.

I've already started a fresh workspace, so I'm not sure if this is still useful. I'm not able to attach it (upload doesn't work), but I've pasted it here: https://gist.github.com/glen-84/7908933433c3dce60fbf

> In case the Terminal View had been open in your workspace at the time you uninstalled it, this might be normal behavior: Platform/UI tries to restore your perspective on restart, but the plug-in implementing the view (and its icon) is no longer there.

This is messy IMHO. If it's not able to determine that the plug-in is missing before attempting to open the view, then perhaps the uninstall process should close all associated views. Anyway, this is not specific to this plug-in.

Thanks.
Comment 3 Jonah Graham CLA 2020-05-01 10:08:33 EDT
The Terminal component of the Eclipse Ecosystem has a new home. The Terminal is now part of the Eclipse CDT project[1].

This change means a new Git repo[2], P2 site[3] and Bugzilla component. The terminal will continue to be delivered as part of the quarterly Simultaneous Release of Eclipse as well.

The marketplace entry[4] had not been updated in a few years. It will once again install the latest release of the terminal on the latest release of the whole IDE (currently 2020-03).

If this bug is no longer relevant, please feel free to comment or close the bug. If you can confirm if this issues still occurs in the latest release please do let me know in a comment.

[1] https://wiki.eclipse.org/CDT/User/NewIn911
[2] https://git.eclipse.org/c/cdt/org.eclipse.cdt.git (in the terminal directory)
[3] current release is 9.11 - P2 site https://download.eclipse.org/tools/cdt/releases/9.11/
[4] https://marketplace.eclipse.org/content/tm-terminal

(This comment was added to all open terminal bugs along with changing the Product/component pair to CDT/terminal.)
Comment 4 Jonah Graham CLA 2020-05-04 07:22:44 EDT
Created attachment 282684 [details]
what the error looks like to the user (with Details pressed)

This is indeed not a terminal specific problem. Any view that is open and whose plug-in is no longer available displays such an error.

Moving to Eclipse Platform, but it sounds like I should be able to find a duplicate on this item.
Comment 5 Jonah Graham CLA 2020-05-04 07:24:04 EDT
Screenshot if for 4.15 where I just reproduced this, but AFAIK this problem has been around forever?
Comment 6 Rolf Theunissen CLA 2020-05-04 12:15:27 EDT
This should have been fixed by Bug 473845, apparently there are some leftovers.