Community
Participate
Working Groups
The full mode, introduced in bug 427999, does not hide the main menu. The rationale is that users switching accidentally to full mode via the keyboard shortcut would be confused how to switch back to normal mode. The main menu is there chance to do this (assuming they do not know the keyboard shortcut). I think we should give a choice to users and have a preference that allows the main menu to hide in full mode. The preference will be off by default, so those who enable it should know the shortcut.
Can I make this another command (hide menu) or do you insist in rolling that into the full screenshot? I think it is really dangerous for the user and he should select that actively. I think if he does we should also display a warning dialog how he can restore the menu.
Should have been: Can I make this another command (hide menu) or do you insist in rolling that into the "Toogle Visibility of all Toolbars"?
If the ultimate goal is to have a full screen mode then let's have a single action with name "Toggle Full Screen Mode". This way if I accidentally toggle the full screen mode, and I don't have a main menu, and I don't know the toggle shortcut, I can still hit Ctrl+3 and search for "full screen" mode, and I will be safe. If we are going to show a warning message then it should be shown regardless of the preference if main menu should be hidden. Looking for a specific action in the main menu is a challenge too :-) Of course, there should be an option "Do not show this again".
Also, the "Toogle Visibility of all Toolbars" as the current name of the action is not accurate. The view's or editor's toolbars are not affected at all... and so it should be.
(In reply to Kaloyan Raev from comment #4) > Also, the "Toogle Visibility of all Toolbars" as the current name of the > action is not accurate. The view's or editor's toolbars are not affected at > all... and so it should be. What would be good and catch name?
"Toggle Full Screen Mode" :o)
(In reply to Kaloyan Raev from comment #6) > "Toggle Full Screen Mode" :o) Even without hiding the menu? And I'm definitely -1 on hiding the menu in the same action. The menu is already integrated into the main window for Linux and Mac so this would be a special thing for Windows user.
(In reply to Kaloyan Raev from comment #6) > "Toggle Full Screen Mode" :o) And the shortcut is F11. Like any browser it does since years :-)
(In reply to Andrey Loskutov from comment #8) > (In reply to Kaloyan Raev from comment #6) > > "Toggle Full Screen Mode" :o) > > And the shortcut is F11. Like any browser it does since years :-) F11 is taken by debug last launched application. Convince them to release it or change there shortcut and I use it in platform. I was trying to find something similar to Ctrl+M which maximizes the current part.
(In reply to Lars Vogel from comment #7) > (In reply to Kaloyan Raev from comment #6) > > "Toggle Full Screen Mode" :o) > > Even without hiding the menu? And I'm definitely -1 on hiding the menu in > the same action. The menu is already integrated into the main window for > Linux and Mac so this would be a special thing for Windows user. If we are aiming for real full screen mode then let's try to do it. My understanding for full mode is: 1. Main windows is maximized (not done). 2. Main menu hidden (not done). 3. Main toolbar hidden (done). 4. Trim bars hidden (done). The main concern about hiding the main menu is that the users won't know how to restore to normal mode. Then let's introduce some float button or similar that visually makes it obvious how to restore to normal mode.
Having a globally available "Exit Full screen mode" menu item in the context menu would be sufficient, I think.
(In reply to Kaloyan Raev from comment #10) > My understanding for full mode is: > 1. Main windows is maximized (not done). > 2. Main menu hidden (not done). > 3. Main toolbar hidden (done). > 4. Trim bars hidden (done). I think it is valuable to hide the toolbars even if you not have a maximized window, give the user more flexibility. For hiding the menu see comment 7. But +1 for having another action to hide the menu. I'm also OK to accept a patch to combine all of these points above for a real full screen mode but I suggest to handle this via a new bug. If you want this, the title of the maximized window must say "Press ESC (or something else) to leave full screen mode" and react to this. Ability to hide toolbars is valuable by itself, hiding the menu should be part of this bug. A "presentation mode" should be handled by another bug.
(In reply to Lars Vogel from comment #12) > (In reply to Kaloyan Raev from comment #10) > > My understanding for full mode is: > > 1. Main windows is maximized (not done). > > 2. Main menu hidden (not done). > > 3. Main toolbar hidden (done). > > 4. Trim bars hidden (done). > > I think it is valuable to hide the toolbars even if you not have a maximized > window, give the user more flexibility. For hiding the menu see comment 7. At least for me this has no value, so I am not requesting this. I need to hide the main menu only as a part of a "Toggle (real) full screen mode" action. > But +1 for having another action to hide the menu. I'm also OK to accept a > patch to combine all of these points above for a real full screen mode but I > suggest to handle this via a new bug. If you want this, the title of the > maximized window must say "Press ESC (or something else) to leave full > screen mode" and react to this. Can we just use this bug? This is the actual purpose I opened it. I can change the bug title if necessary. > Ability to hide toolbars is valuable by itself, hiding the menu should be > part of this bug. A "presentation mode" should be handled by another bug. Not that "presentation mode" and "full screen mode" are different things. Presentation mode is full screen mode + scaling up some UI elements (like editor font). Also, note that the "Toogle Visibility of all Toolbars" action introduced in bug 427999 does not play well with the existing "Toggle Toolbar Visibility" action. The latter does not always work correctly after executing the former one.
Thanks, Kaloyan, I relabeled Bug 427999 to describe its purpose. It is now called "Introduce a mode allowing the user to hide all trimbars of the main window". >Also, note that the "Toogle Visibility of all Toolbars" action introduced in >bug 427999 does not play well with the existing "Toggle Toolbar Visibility" >action. The latter does not always work correctly after executing the former >one. Like I said before, for me hidding to toolbars has significant value and for me also hidding at the same time the menu has a significant risk. Still a -1 from me.
(In reply to Lars Vogel from comment #14) > >Also, note that the "Toogle Visibility of all Toolbars" action introduced in >bug 427999 does not play well with the existing "Toggle Toolbar Visibility" >action. The latter does not always work correctly after executing the former >one. I have a look on that.
FYI - shortcut has been removed, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=427999#c47
Mass move to 4.7 as M7 is approaching. Please move back in case you are planning to fix it for Neon.
