Bug 4789 - XP - Look and feel problems (1GIGGKM)
Summary: XP - Look and feel problems (1GIGGKM)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 2.0   Edit
Hardware: All Windows XP
: P2 normal (vote)
Target Milestone: ---   Edit
Assignee: Steve Northover CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 4823 4825 4827 8906 9289 12774 (view as bug list)
Depends on:
Blocks:
 
Reported: 2001-10-11 14:23 EDT by Steve Northover CLA
Modified: 2004-04-21 00:42 EDT (History)
8 users (show)

See Also:


Attachments
XP manifest file to enable new L&F (1.06 KB, text/plain)
2002-03-27 11:35 EST, Mike Wilson CLA
no flags Details
My toolbar without the manifest (3.83 KB, image/png)
2002-08-23 06:54 EDT, Johan Compagner CLA
no flags Details
My toolbar with the manifest (4.94 KB, image/png)
2002-08-23 06:54 EDT, Johan Compagner CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Northover CLA 2001-10-11 14:23:02 EDT
NOTES:
Comment 1 DJ Houghton CLA 2001-10-29 16:38:37 EST
PRODUCT VERSION:

These are from an email message from GA.  We need to investigate each.

File Dialog
	Open notepad and do File > Open
	vs.
	Clicking Browse... in the zip file import wizard

	- combo boxes are different
	- buttons are different
	- bottom right corner of dialog has different looking grab area
	- panel at the left side looks different
	- tool bar in top right of dialog looks different

Wizards
	- our wizard buttons (next, back etc) look different than theirs

Dialogs
	- our ok/cancel buttons look different than theirs

Our notebook (the platform one) looks different
	- New java project 
	- Fill in the name & hit next
	-  I believe this notebook is the platform widget (as opposed to the one we use for views)

The scripted Java Script Example preference page does not size properly 
	To be honest I don't know if it works on non xp <g>.

Comment 2 Mike Wilson CLA 2001-12-10 14:27:34 EST
It is important for us to have the correct look.
Comment 3 Mike Wilson CLA 2002-03-27 11:34:29 EST
Setting this PR up as the holder of all XP L&F issues.
Comment 4 Mike Wilson CLA 2002-03-27 11:35:39 EST
Created attachment 523 [details]
XP manifest file to enable new L&F
Comment 5 Mike Wilson CLA 2002-03-27 11:38:46 EST
I've attached the manifest file that I've been using to enable the new XP look 
and feel. With this in place, most of the original issues reported by GA are 
fixed. However, there are several new ones:

  - icons overlap text in TabFolder
  - ToolItems flash when resizing
  - label of Group within Group uses wrong font (see ControlExample)

Comment 6 Mike Wilson CLA 2002-04-04 09:05:35 EST
*** Bug 12774 has been marked as a duplicate of this bug. ***
Comment 7 Christophe Cornu CLA 2002-04-19 17:25:53 EDT
Workarounds checked-in for
  - icons overlap text in TabFolder
  - label of Group within Group uses wrong font (see ControlExample)

Other issues:
 - Group flashing when mouse cursor moved over text
 - ControlExample Shell is too small, Tab 'Slider & Scale' doesn't fit in on XP 
with either comctrl 6.0 or 5.8
 - Image Buttons have the classic look
Comment 8 Veronika Irvine CLA 2002-05-15 16:45:07 EDT
*** Bug 9289 has been marked as a duplicate of this bug. ***
Comment 9 Veronika Irvine CLA 2002-05-15 16:46:17 EDT
*** Bug 8906 has been marked as a duplicate of this bug. ***
Comment 10 Steve Northover CLA 2002-05-15 16:50:45 EDT
These were recreated using only DLL calls.  We tried to work around them but 
could not.  It's just platform behavior:

 - Group flashing when mouse cursor moved over text
 - Image Buttons have the classic look

This was a problem in the ControlExample that has been fixed:

 - ControlExample Shell is too small, Tab 'Slider & Scale' doesn't fit in on XP 
with either comctrl 6.0 or 5.8
Comment 11 Johan Compagner CLA 2002-05-23 13:17:55 EDT
first: Is this bug fixed in F1??

if so then this bug is not fixed because for example all the buttons that 
eclipse display are different then the onces other windows programs do display
my buttons are not that dark gray rectangles eclipse display but light gray 
buttons with blue border if it has focus/default. The buttons also "miss" one 
corner.

i do use another lnf/style in winxp. But eclipse should follow that style as 
much as possible yes? (for example: scrollbars follow perfectly)
Comment 12 Christophe Cornu CLA 2002-05-23 14:04:06 EDT
Johan:
Please try adding a manifest to enable the XP look and feel.
- open the attachment (see link above: 'Attachments: 03/27/02 11:35')
- save the file to your <eclipse>/jre/bin directory, under the 
name 'javaw.exe.manifest' (without the quotes)
- restart eclipse.
Comment 13 Johan Compagner CLA 2002-05-23 15:13:04 EDT
i don't have a <eclipse>\jre\bin directory.

But i have tried this:

added the manifest file in:

c:\jdk1.4\bin\
c:\jdk1.4\jre\bin\
and i create the 
c:\eclipse\jre\bin dir and added that manifest there

with all tree i tried to start eclipse but my buttons never change

And why do i have to add a manifest file to a jre\bin dir to enable this?
can't eclipse handle this by itself?

Comment 14 Mike Wilson CLA 2002-05-23 15:20:08 EDT
For R2.0, eclipse is relying on the external manifest file to get the current 
XP look and feel. We have investigated alternatives, but have not been 
able to find one which does not cause performance issues and require 
changes to the structure of the SWT DLL.

Re-opening bug to indicate that this work is ongoing.
Comment 15 Mike Wilson CLA 2002-05-23 15:20:38 EDT
Marking PR as LATER to indicate that this work will happen post R2.0.
Comment 16 Mike Wilson CLA 2002-05-24 19:23:34 EDT
*** Bug 4823 has been marked as a duplicate of this bug. ***
Comment 17 Mike Wilson CLA 2002-05-24 19:26:15 EDT
*** Bug 4825 has been marked as a duplicate of this bug. ***
Comment 18 Mike Wilson CLA 2002-05-24 19:26:59 EDT
*** Bug 4827 has been marked as a duplicate of this bug. ***
Comment 19 Johan Compagner CLA 2002-05-30 03:19:11 EDT
first i want to say that it works for me now (i had also a javaw.exe in the 
windows\system dir)

I looked for some more info about this and i say examples that opera also 
should use a manifest file like opera.exe.manifest with its exe to get it 
working. 

Now i don't care about a manifest file for eclipse but why can't it really be 
a eclipse.exe.manifest and not a javaw.exe.manifest in a jdk/jre installation?

Eclipse.exe itself should not call javaw.exe but do the things javaw.exe does 
itself. So that windows sees eclipse.exe in the taskmanager for example. This 
also does have one other big plus: Eclipse is not seens as another javaw.exe 
program so eclipse will not be grouped with other java programs. (if i have 
multiply java programs open including eclipse then winXP will group them 
together, that's a bit stupid)
Comment 20 Steve Northover CLA 2002-05-30 10:20:35 EDT
This is beyond our control.  Eclipse.exe needs to invode javaw.exe because 
Eclipse is written in java and relies on the fact that java runs in another 
process.
Comment 21 Veronika Irvine CLA 2002-08-20 15:15:46 EDT
Investigate what can now be addressed.
Comment 22 Veronika Irvine CLA 2002-08-20 17:31:36 EDT
Group flashing when mouse cursor moved over text
Fixed in > 20020820.
Comment 23 Veronika Irvine CLA 2002-08-20 17:35:53 EDT
Image Buttons have the classic look
- this is addressed in bug report 18699
Comment 24 Veronika Irvine CLA 2002-08-20 17:37:38 EDT
Fixed.  No unaddressed issues remaining.
Comment 25 Johan Compagner CLA 2002-08-23 06:54:04 EDT
Created attachment 1875 [details]
My toolbar without the manifest
Comment 26 Johan Compagner CLA 2002-08-23 06:54:43 EDT
Created attachment 1876 [details]
My toolbar with the manifest
Comment 27 Johan Compagner CLA 2002-08-23 07:56:03 EDT
If i use the manifest i get a horrible toolbar.
It is suddenly bigger,(smaller would be nice)
but with a not so nice white line around the normal size.

See my 2 attachements
Comment 28 Steve Northover CLA 2002-08-23 09:33:59 EDT
Johan, this PR was closed because it was a catch all for "many things bad with 
XP look and feel".  A better approach is to enter specific PR's against each 
failure, otherwise we lose track of what is fixed and we end up never closing 
this PR.

Can you enter a new PR with the attachments describing what you are seeing so 
that we can leave this one closed?
Comment 29 Johan Compagner CLA 2002-08-23 09:43:10 EDT
done: 22767