Community
Participate
Working Groups
The toolbar should be easily reconfigurable through a right click on it instead of going all the way Windows -> Customize Perspective which is all but intuitive.
+1 I believe allowing Right-Click > Customize (same as on perspective switcher button) would be enough.
Technically, it seems like the MToolControl and MToolbarManager are missing fields to define menus; and the ToolBarManagerRenderer and the ToolControlRenderer have nothing to process in order to add contextual menu.
Have a look how we do the menu for ToolControl in ToolControlRenderer (send from mobile without laptop so classes might be slightly different)
(In reply to Lars Vogel from comment #3) > Have a look how we do the menu for ToolControl in ToolControlRenderer (send > from mobile without laptop so classes might be slightly different) The only part related to menu in these classes in an hardcoded Menu entry (Restore Hidden Elements...). The suggested operation (open customize perspecitve dialog) cannot be hardcoded, and I couldn't find a field somewhere on the ToolControl model that can be used to add menus from .e4xmi.
Would it be do-able to have the renderer also look for a org.eclipse.ui.menus/menuControbution extension with a specific URL, such as popup:toolbar ?
(In reply to Mickael Istria from comment #5) > Would it be do-able to have the renderer also look for a > org.eclipse.ui.menus/menuControbution extension with a specific URL, such as > popup:toolbar ? No the renderers are not allowed to have a dependency to e3 API. But you could make it for model fragment contributions which define popups.
New Gerrit change created: https://git.eclipse.org/r/60199
Is there any guarantee that the provided patch will be considered for merging in M5?
(In reply to Mickael Istria from comment #8) > Is there any guarantee that the provided patch will be considered for > merging in M5? This is OS development, if someone finds the time, he considers it. I like the idea, so I plan to review it, but as I do this in my unpaid time I personally cannot guarantee this.
(In reply to Lars Vogel from comment #9) > I like the idea, so I plan to review it Ok thanks. Feel free to tell me if there is anything I can do to ease it.
Mass move to M6
New Gerrit change created: https://git.eclipse.org/r/67786
@Lars: I would like to merge it soon. Can you please have a look?
@Brian: Do you think you could have a look to the couple of submitted review for that feature?
Gerrit change https://git.eclipse.org/r/67786 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=029449cf3e07e78bd576fe6cbe0769d2c8dafe22
I don't like the identifier 'popup:toolbar' as it's not sufficiently descriptive. This seems to potentially introduce a menu on all ToolControls regardless of whether they are in the org.eclipse.ui.main.toolbar. It would make more sense if this was targeted to the Spacer Glue elements? Rather than modify the LegacyIDE.e4xmi files, I think it could be better to use a model processor to introduce the required changes to the model. I think this will cause requests for others to be able to add to a main-toolbar menu I'm +1 for this change to go in to M6 and figuring out a better way to get it to work for M7.
Mass move to 4.6 RC1. We might push out more to 4.7.
M7 feature freeze is done. Let's slip it to next version then.
(In reply to Eclipse Genie from comment #15) > Gerrit change https://git.eclipse.org/r/67786 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.git/commit/ > ?id=029449cf3e07e78bd576fe6cbe0769d2c8dafe22 I do not see *any* popup menu on toolbar. Was it ever working? If yes, by which magic? If not - what was missing to complete this task? I've stumbled over this change while trying to understand differences between /org.eclipse.platform/LegacyIDE.e4xmi /org.eclipse.ui.workbench/LegacyIDE.e4xmi via bug 528890. This is the only difference I've found so far (except the initial window size and the changes added by bug 528890 itself).
(In reply to Andrey Loskutov from comment #19) > Was it ever working? No. > If not - what was missing to complete this task? I don't remember, but I'd say it's just missing a good patch. > This is the only difference I've found so far (except the initial window > size and the changes added by bug 528890 itself). If this is an issue, I guess you can revert this change since it's not working anyway.
New Gerrit change created: https://git.eclipse.org/r/142530
Gerrit change https://git.eclipse.org/r/142530 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=b69e9a458f1d2fa0938d552725f7f19e23109838
(In reply to Mickael Istria from comment #20) > If this is an issue, I guess you can revert this change since it's not > working anyway. It is at least surprising and inconsistent. I've removed this.
