Community
Participate
Working Groups
If a problem occurs when instantiating a browser, like e.g. SWTError triggered by GTK3 and mozilla, the Browser widget doesn't dispose itself: In the constructor for org.eclipse.swt.browser.Browser as shown below, and exception may be thrown in webBrowser.create (parent, style); If that happens, dispose() won't be called, but the corresponding Control was already added to the parent composite. public Browser (Composite parent, int style) { super (checkParent (parent), checkStyle (style)); userStyle = style; String platform = SWT.getPlatform (); if ("gtk".equals (platform)) { //$NON-NLS-1$ parent.getDisplay ().setData (NO_INPUT_METHOD, null); } style = getStyle (); webBrowser = new BrowserFactory ().createWebBrowser (style); if (webBrowser != null) { webBrowser.setBrowser (this); webBrowser.create (parent, style); /** may throw SWTError */ return; } dispose (); SWT.error (SWT.ERROR_NO_HANDLES); }
Can you give a code which reproduce this bug?
Sure, please find below - let me know if this helps. Basically what I'm trying to do doing is: void Control addTextControl(Composite parent) { Control control = null; try { control = new Browser(parent, SWT.BORDER); fillBrowserControlWithContent(control); } catch (SWTError e) { /** In the case I'm reported, the Browser's constructor has thrown an SWTError triggered by GTK3 and mozilla: * " [Browser style SWT.MOZILLA and Java system property org.eclipse.swt.browser.DefaultType=mozilla are not * supported with GTK 3 as XULRunner is not ported for GTK 3 yet]" * * control will stil be null, but the Browser's widget wasn't disposed, so it is still a child of 'parent'. */ /** Browser didn't work out: Use the old technique */ control = new ScrolledFormText(comp, SWT.BORDER | SWT.H_SCROLL | SWT.V_SCROLL | SWT.WRAP, true); fillFormTextControlWithContent(control); }
Please ignore the 'void' in my previous sample - I really should get a coffee before posting sample code - sorry for that.
What is the state of this bug? Mozilla support has been removed so maybe we should close this one?
It would be useful to wrap this around in a try/catch block.
No comment from the reporter in awhile so I am going to close this. Please open a new ticket if you face this issue using SWT 4.10 with WebKit2.
I am on the SWT3.121.0 version. When trying to create a browser instance for Edge and not having an edge on that system I am getting a SWT error and to handle that I am catching that error and trying to create another instance using the IE browser. But the Edge instance is not getting disposed of itself so I disposed of it via code but when Calling Browser.clearSessions() after creating the IE browser instance it is still using the Edge instance and going inside Edge class and throwing SWT error. How to dispose of the previous Browser instance? Code for the same - public static Browser getBrowserInstance(Composite parent, int style) { try { browser = new Browser(parent, style);\ } catch (SWTError error) { for (Control children : parent.getChildren()) { if (children instanceof Browser) { children.dispose(); parent.layout(true, true); } } if (error.code == SWT.ERROR_NOT_IMPLEMENTED) { browser = new Browser(parent, SWT.NONE); } } return browser; }
SWT development moved to https://github.com/eclipse-platform/eclipse.platform.swt . So if you can reproduce with latest version of SWT and ideally come up with snippet to demonstrate the issue please report there.
