Community
Participate
Working Groups
IWorkspaceRunnable interface is structurally equivalent to ICoreRunnable and can be changed to extend ICoreRunnable. Once this is done, IWorkspace.run(IWorkspaceRunnable, IProgressMonitor) and IWorkspace.run(IWorkspaceRunnable, ISchedulingRule, int, IProgressMonitor) methods can be changed to accept ICoreRunnable instead of IWorkspaceRunnable. Eventually, IWorkspaceRunnable can be deprecated in favor of ICoreRunnable.
New Gerrit change created: https://git.eclipse.org/r/54815
New Gerrit change created: https://git.eclipse.org/r/54933
Sorry, but where can the interface ICoreRunnable be found? I just checked out the latest sources of platform.runtime and platform.ui. But I can't find that interface anywhere. From the import I would assume that the interface should be located in the org.eclipse.core.runtime project, but it doesn't contain that interface in master.
(In reply to Dirk Fauth from comment #3) It is in rt.equinox.bundles (see commit: http://git.eclipse.org/c/equinox/rt.equinox.bundles.git/commit/?id=8a8f71942a1034d52acef423a973eee8415f576b)
Gerrit change https://git.eclipse.org/r/54815 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/?id=1c9dd55b6e0b1ab38d835b777ccf00d9356d9827
M2 is over.
Gerrit change https://git.eclipse.org/r/54933 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=681252c4498fe82aba0acbb72fb86bdcb62a5175
Marking as fixed, as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=681252c4498fe82aba0acbb72fb86bdcb62a5175 fixes the references.
Created attachment 256737 [details] Image shows an unused import is causing compilation errors There is something to fix, related to solution of bug 476142 Description Resource Path Location Type The import org.eclipse.core.resources.IWorkspaceRunnable is never used AbstractWorkspaceOperation.java /org.eclipse.ui.ide/src/org/eclipse/ui/ide/undo line 23 Java Problem
(In reply to Patrik Suzzi from comment #9) > Created attachment 256737 [details] > Image shows an unused import is causing compilation errors Sorry, reopening for the fix.
New Gerrit change created: https://git.eclipse.org/r/56389
Gerrit change https://git.eclipse.org/r/56389 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1b7a326346773f9265c16e6faac08705c6f89b39
(In reply to Eclipse Genie from comment #12) > Gerrit change https://git.eclipse.org/r/56389 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=1b7a326346773f9265c16e6faac08705c6f89b39 Fixed, thanks Patrik for reporting.
I'd like to reopen this and discuss a subtle change in the API (CC from the gerrit review https://git.eclipse.org/r/#/c/54815/): I wonder about the subtle change of the contract of IWorkspaceRunnable#run. It used to define that a cancelled runnable should throw OperationCancelException whereas ICoreRunnable defines CoreException with a cancel status as the proper reaction to cancellation. Since IWorkspace.run(..) also describes the OperationCancelException as the result of a cancelled runnable, shouldn't the CoreException with cancel status be caught in the Workspace#run and an OCE be thrown? Alternatively the contract should be clarified.
(In reply to Sebastian Zarnekow from comment #14) Will your concerns be addressed by https://git.eclipse.org/r/#/c/56850/ ?
