Community
Participate
Working Groups
IPluginDescriptor was only used for plug-ins using org.eclipse.core.runtime.compatibility, see its Javadoc. This plug-in will be deleted via Bug 394739 hence we should mark IPluginDescriptor for deletion (or delete it directly as a result of solving Bug 394739).
In fact, all these should be removed: ILibrary IPlatformRunnable IPluginDescriptor IPluginPrerequisite IPluginRegistry I vote for remove immediately since they are deprecated since Eclipse 3.0 and are useless without the implementations from org.eclipse.core.runtime.compatibility
Those classes are referenced by a lot of classes and methods, e.g. IPluginDescriptor has over 70 references. We would have to check whether all those are already deprecated and then also have to mark all those for deletion.
(In reply to Dani Megert from comment #2) > Those classes are referenced by a lot of classes and methods, e.g. > IPluginDescriptor has over 70 references. We would have to check whether all > those are already deprecated and then also have to mark all those for > deletion. I think the best is to prepare a Gerrit review for the removal and see from this. Mat, are you interested in providing such a Gerrit?
(In reply to Lars Vogel from comment #3) > (In reply to Dani Megert from comment #2) > > Those classes are referenced by a lot of classes and methods, e.g. > > IPluginDescriptor has over 70 references. We would have to check whether all > > those are already deprecated and then also have to mark all those for > > deletion. > > I think the best is to prepare a Gerrit review for the removal and see from > this. Mat, are you interested in providing such a Gerrit? There will be several ones since it crosses repositories.
Verifying everything is marked as deprecated would definetely help for the visibility of the problem. At a minimum many methods will have to be made noop in order to prevent exception.
(In reply to Mat Booth from comment #1) > In fact, all these should be removed: > IPlatformRunnable EMF makes use of IPlatformRunnable reducing the deprecation inconvenience by: @SuppressWarnings("deprecation") interface DeprecatedPlatformRunnable extends org.eclipse.core.runtime.IPlatformRunnable { // Empty extension to limit the effect of suppressing the deprecation warning. } It looks as if the deprecation effort has been deferred...
(In reply to Mat Booth from comment #1) > In fact, all these should be removed: > > ILibrary > IPlatformRunnable > IPluginDescriptor > IPluginPrerequisite > IPluginRegistry > > I vote for remove immediately since they are deprecated since Eclipse 3.0 > and are useless without the implementations from > org.eclipse.core.runtime.compatibility http://help.eclipse.org/mars/index.jsp?topic=%2Forg.eclipse.platform.doc.isv%2Fporting%2Fremovals.html announces removal of IPlatformRunnable in June 2017. The others still need an announcement and two year notice period.
New Gerrit change created: https://git.eclipse.org/r/136671
Planning to delete IPluginDescriptor and related API early in 4.12. Ed, is EMF still using IPluginDescriptor?
New Gerrit change created: https://git.eclipse.org/r/136672
What about org.eclipse.ui.plugin.AbstractUIPlugin.AbstractUIPlugin(IPluginDescriptor)
New Gerrit change created: https://git.eclipse.org/r/136706
(In reply to Thomas Watson from comment #11) > What about > org.eclipse.ui.plugin.AbstractUIPlugin.AbstractUIPlugin(IPluginDescriptor) Thanks, see new Gerrit. Note that this is planned for early 4.12. I don't want to break clients shortly before a release.
(In reply to Lars Vogel from comment #9) > Planning to delete IPluginDescriptor and related API early in 4.12. > > Ed, is EMF still using IPluginDescriptor? EMF is still using this method. But also when it gets removed, how would older EMF versions behave on a newer platform then? I'll provide a patch for EMF. The method in doubt is deprecated since 2004.
(In reply to Karsten Thoms from comment #14) > > Ed, is EMF still using IPluginDescriptor? > > EMF is still using this method. But also when it gets removed, how would > older EMF versions behave on a newer platform then? The uses of IPluginDescriptor seem to be in deprecated methods so they shouldn't get called by reasonable code. Not a problem. More serious is IPlatformRunnable, which is actively used by the codegen Generator class. Therefore if the platform removed IPlatformRunnable today, there would no graceful transition. Since removal of IPluginDescriptor undermines the ongoing claim to perfect 2.x API preservation, it would be good to eliminate all active uses of DeprecatedPlatformRunnable in EMF 2.18 so that 2.18 and upwards can be used on platforms without IPlatformRunnable 2.17 and lower will be unable to genmodel.
(In reply to Ed Willink from comment #15) > > Since removal of IPluginDescriptor undermines the ongoing claim to perfect > 2.x API preservation, it would be good to eliminate all active uses of > DeprecatedPlatformRunnable in EMF 2.18 so that 2.18 and upwards can be used > on platforms without IPlatformRunnable 2.17 and lower will be unable to > genmodel. Yes, deleting all uses of IPlatformRunnable would be good at this point. It's only partially done: https://bugs.eclipse.org/bugs/show_bug.cgi?id=531159 There's currently no Bugzilla for complete removal.
Gerrit change https://git.eclipse.org/r/136671 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/?id=d3575fbfbca9bd0513940989619ab615a1aeaf67
New Gerrit change created: https://git.eclipse.org/r/139303
New Gerrit change created: https://git.eclipse.org/r/139305
Gerrit change https://git.eclipse.org/r/139303 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=cc303e995382f0e2cdd9fa7f8899347d46aeb1bd
Gerrit change https://git.eclipse.org/r/136706 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b13cf90b8027239b76e42866ed8a5aa47385be08
Gerrit change https://git.eclipse.org/r/136672 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=8c0a25208758847b86e9edba54a926631461d088
Lars, please fix - API errors in org.eclipse.help.ui and org.eclipse.core.runtime, - compile errors in org.eclipse.ui.tests.
New Gerrit change created: https://git.eclipse.org/r/139326
New Gerrit change created: https://git.eclipse.org/r/139327
Gerrit change https://git.eclipse.org/r/139326 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=1e1be78259565733f2e4f8860d19fea804561fe3
Gerrit change https://git.eclipse.org/r/139327 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=acfe5d2abdb943961ac8c486bccd359fba6c213e
New Gerrit change created: https://git.eclipse.org/r/139331
(In reply to Andrey Loskutov from comment #23) > Lars, please fix > - API errors in org.eclipse.help.ui and org.eclipse.core.runtime, > - compile errors in org.eclipse.ui.tests. Lars, why did you not see those?
(In reply to Eclipse Genie from comment #27) > Gerrit change https://git.eclipse.org/r/139327 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/ > ?id=acfe5d2abdb943961ac8c486bccd359fba6c213e This does not fix API error on org.eclipse.help.ui.
Gerrit change https://git.eclipse.org/r/139331 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=c5b196aee37d6953a9fe01054f362004da6730b6
Thanks, Andrey. Should be fixed now.
(In reply to Lars Vogel from comment #32) > Thanks, Andrey. Should be fixed now. Can you please respond to comment 29. Thanks.
(In reply to Andrey Loskutov from comment #30) > This does not fix API error on org.eclipse.help.ui. It does for me. Did you try with a clean build? API tools usually require a clean build. If you still see the API error, please use the quick fix directly, as I cannot see this error.
(In reply to Dani Megert from comment #33) > (In reply to Lars Vogel from comment #32) > > Thanks, Andrey. Should be fixed now. > Can you please respond to comment 29. Thanks. API tools remain instable for me. See for example comment 34.
(In reply to Lars Vogel from comment #34) > (In reply to Andrey Loskutov from comment #30) > > This does not fix API error on org.eclipse.help.ui. > > It does for me. Did you try with a clean build? API tools usually require a > clean build. That is just not true. Please file a bug report if you see this.
(In reply to Lars Vogel from comment #35) > API tools remain instable for me. See for example comment 34. Do you use the correct baseline (4.11)?
New Gerrit change created: https://git.eclipse.org/r/139338
(In reply to Lars Vogel from comment #34) > (In reply to Andrey Loskutov from comment #30) > > This does not fix API error on org.eclipse.help.ui. > > It does for me. Did you try with a clean build? Sure. (In reply to Eclipse Genie from comment #38) > New Gerrit change created: https://git.eclipse.org/r/139338 Not sure how you got the *old* bundle version for the filter. With the current version the error is gone.
(In reply to Eclipse Genie from comment #38) > New Gerrit change created: https://git.eclipse.org/r/139338 This build fails because "Only qualifier changed for (org.eclipse.help.ui/4.1.400.v20190322-1607)" and also patch before failed, https://git.eclipse.org/r/#/c/139327/ ! Looks like it was created on *old* bundle version and only rebased on server, means Lars had very old source version (before 4.11) and also didn't verified the build result. I will bump the version and fix the filter again.
(In reply to Andrey Loskutov from comment #40) > (In reply to Eclipse Genie from comment #38) > > New Gerrit change created: https://git.eclipse.org/r/139338 > > This build fails because "Only qualifier changed for > (org.eclipse.help.ui/4.1.400.v20190322-1607)" and also patch before failed, > https://git.eclipse.org/r/#/c/139327/ ! > > Looks like it was created on *old* bundle version and only rebased on > server, means Lars had very old source version (before 4.11) and also didn't > verified the build result. > > I will bump the version and fix the filter again. Thanks Andrey. I don't see how it can be that hard to make this right in the first run.
Gerrit change https://git.eclipse.org/r/139338 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=4138f8e7ca65457ae8d7fa6a3e66075dca74e80d
(In reply to Dani Megert from comment #41) > I don't see how it can be that hard to make this right in the first run. Sorry, this was not constructive. There can be several reasons why the errors were not seen: - old target platform - wrong baseline - reduced severity for some problems in the workspace from Error to Warning/Ignore
Gerrit change https://git.eclipse.org/r/139305 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.ui.git/commit/?id=76e7d7d7aca41a15106c14f0c652cd1fb483e491
