Bug 475651 - Data race inside org.eclipse.search2.internal.ui.InternalSearchUI.fSearchJobs
Summary: Data race inside org.eclipse.search2.internal.ui.InternalSearchUI.fSearchJobs
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Search (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Search-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: investigate
Depends on:
Blocks:
 
Reported: 2015-08-23 02:04 EDT by Yilong Li CLA
Modified: 2019-07-19 17:02 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yilong Li CLA 2015-08-23 02:04:05 EDT
Here is the race report given by a dynamic race detector:
Data race on field java.util.HashMap.$state: {{{
    Concurrent read in thread T1 (locks held: {Monitor@573aeb9d, Monitor@12df1c62})
 ---->  at org.eclipse.search2.internal.ui.InternalSearchUI.isQueryRunning(InternalSearchUI.java:187)
        at org.eclipse.search.ui.NewSearchUI.isQueryRunning(NewSearchUI.java:236)
        at org.eclipse.search.ui.text.AbstractTextSearchViewPage.isQueryRunning(AbstractTextSearchViewPage.java:1271)
        at org.eclipse.search.ui.text.AbstractTextSearchViewPage.access$3(AbstractTextSearchViewPage.java:1268)
        at org.eclipse.search.ui.text.AbstractTextSearchViewPage$UpdateUIJob.runInUIThread(AbstractTextSearchViewPage.java:147)
        at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:97)
        at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
        at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
        - locked Monitor@12df1c62 at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:131) 
        at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3794)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3433)
        at org.eclipse.jface.operation.ModalContext$ModalContextThread.block(ModalContext.java:172)
        at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:387)
        at org.eclipse.jface.dialogs.ProgressMonitorDialog.run(ProgressMonitorDialog.java:500)
        at org.eclipse.search2.internal.ui.InternalSearchUI.doRunSearchInForeground(InternalSearchUI.java:216)
        at org.eclipse.search2.internal.ui.InternalSearchUI.runSearchInForeground(InternalSearchUI.java:211)
        at org.eclipse.search.ui.NewSearchUI.runQueryInForeground(NewSearchUI.java:187)
        at org.eclipse.search.ui.NewSearchUI.runQueryInForeground(NewSearchUI.java:158)
        at org.eclipse.search.tests.filesearch.AnnotationManagerTest.testSwitchQuery(AnnotationManagerTest.java:184)
        at junit.framework.TestCase.runTest(TestCase.java:176)
        at junit.framework.TestCase.runBare(TestCase.java:141)
        at junit.framework.TestResult$1.protect(TestResult.java:122)
        at junit.framework.TestResult.runProtected(TestResult.java:142)
        at junit.framework.TestResult.run(TestResult.java:125)
        at junit.framework.TestCase.run(TestCase.java:129)
        at junit.framework.TestSuite.runTest(TestSuite.java:252)
        at junit.framework.TestSuite.run(TestSuite.java:247)
        at junit.extensions.TestDecorator.basicRun(TestDecorator.java:23)
        at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
        at junit.framework.TestResult.runProtected(TestResult.java:142)
        at junit.extensions.TestSetup.run(TestSetup.java:27)
        at junit.framework.TestSuite.runTest(TestSuite.java:252)
        at junit.framework.TestSuite.run(TestSuite.java:247)
        at junit.extensions.TestDecorator.basicRun(TestDecorator.java:23)
        at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
        at junit.framework.TestResult.runProtected(TestResult.java:142)
        at junit.extensions.TestSetup.run(TestSetup.java:27)
        at junit.framework.TestSuite.runTest(TestSuite.java:252)
        at junit.framework.TestSuite.run(TestSuite.java:247)
        at junit.framework.TestSuite.runTest(TestSuite.java:252)
        at junit.framework.TestSuite.run(TestSuite.java:247)
        at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:692)
        at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:319)
        at org.eclipse.test.UITestApplication$2.run(UITestApplication.java:197)
        at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
        at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
        - locked Monitor@573aeb9d at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:131) 
        at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3794)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3433)
        at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)
        at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
        at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)
        at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:157)
        at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:654)
        at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
        at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598)
        at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
        at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)
        at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:140)
        at org.eclipse.test.UITestApplication.run(UITestApplication.java:62)
        at org.eclipse.test.UITestApplication.start(UITestApplication.java:212)
        at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
        at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)
        at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)
        at org.eclipse.equinox.launcher.Main.run(Main.java:1515)
        at org.eclipse.equinox.launcher.Main.main(Main.java:1488)
        at org.eclipse.core.launcher.Main.main(Main.java:34)
    T1 is the main thread

    Concurrent write in thread T155 (locks held: {})
 ---->  at org.eclipse.search2.internal.ui.InternalSearchUI.searchJobFinished(InternalSearchUI.java:115)
        at org.eclipse.search2.internal.ui.InternalSearchUI.access$1(InternalSearchUI.java:113)
        at org.eclipse.search2.internal.ui.InternalSearchUI$1.run(InternalSearchUI.java:230)
        at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:119)
    T155 is created by T1
        at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:386)
}}}

org.eclipse.search2.internal.ui.InternalSearchUI.fSearchJobs is a non-thread-safe HashMap.
Comment 1 Yilong Li CLA 2015-08-23 02:08:18 EDT
Another race report related to this one, but on field InternalSearchUI$SearchJobRecord.isRunning:

Data race on field org.eclipse.search2.internal.ui.InternalSearchUI$SearchJobRecord.isRunning: {{{
    Concurrent read in thread T1 (locks held: {Monitor@573aeb9d, Monitor@12df1c62})
 ---->  at org.eclipse.search2.internal.ui.InternalSearchUI.isQueryRunning(InternalSearchUI.java:188)
        at org.eclipse.search.ui.NewSearchUI.isQueryRunning(NewSearchUI.java:236)
        at org.eclipse.search.ui.text.AbstractTextSearchViewPage.isQueryRunning(AbstractTextSearchViewPage.java:1271)
        at org.eclipse.search.ui.text.AbstractTextSearchViewPage.access$3(AbstractTextSearchViewPage.java:1268)
        at org.eclipse.search.ui.text.AbstractTextSearchViewPage$UpdateUIJob.runInUIThread(AbstractTextSearchViewPage.java:147)
        at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:97)
        at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
        at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
        - locked Monitor@12df1c62 at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:131) 
        at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3794)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3433)
        at org.eclipse.jface.operation.ModalContext$ModalContextThread.block(ModalContext.java:172)
        at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:387)
        at org.eclipse.jface.dialogs.ProgressMonitorDialog.run(ProgressMonitorDialog.java:500)
        at org.eclipse.search2.internal.ui.InternalSearchUI.doRunSearchInForeground(InternalSearchUI.java:216)
        at org.eclipse.search2.internal.ui.InternalSearchUI.runSearchInForeground(InternalSearchUI.java:211)
        at org.eclipse.search.ui.NewSearchUI.runQueryInForeground(NewSearchUI.java:187)
        at org.eclipse.search.ui.NewSearchUI.runQueryInForeground(NewSearchUI.java:158)
        at org.eclipse.search.tests.filesearch.AnnotationManagerTest.testSwitchQuery(AnnotationManagerTest.java:184)
        at junit.framework.TestCase.runTest(TestCase.java:176)
        at junit.framework.TestCase.runBare(TestCase.java:141)
        at junit.framework.TestResult$1.protect(TestResult.java:122)
        at junit.framework.TestResult.runProtected(TestResult.java:142)
        at junit.framework.TestResult.run(TestResult.java:125)
        at junit.framework.TestCase.run(TestCase.java:129)
        at junit.framework.TestSuite.runTest(TestSuite.java:252)
        at junit.framework.TestSuite.run(TestSuite.java:247)
        at junit.extensions.TestDecorator.basicRun(TestDecorator.java:23)
        at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
        at junit.framework.TestResult.runProtected(TestResult.java:142)
        at junit.extensions.TestSetup.run(TestSetup.java:27)
        at junit.framework.TestSuite.runTest(TestSuite.java:252)
        at junit.framework.TestSuite.run(TestSuite.java:247)
        at junit.extensions.TestDecorator.basicRun(TestDecorator.java:23)
        at junit.extensions.TestSetup$1.protect(TestSetup.java:23)
        at junit.framework.TestResult.runProtected(TestResult.java:142)
        at junit.extensions.TestSetup.run(TestSetup.java:27)
        at junit.framework.TestSuite.runTest(TestSuite.java:252)
        at junit.framework.TestSuite.run(TestSuite.java:247)
        at junit.framework.TestSuite.runTest(TestSuite.java:252)
        at junit.framework.TestSuite.run(TestSuite.java:247)
        at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:692)
        at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:319)
        at org.eclipse.test.UITestApplication$2.run(UITestApplication.java:197)
        at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
        at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
        - locked Monitor@573aeb9d at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:131) 
        at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3794)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3433)
        at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$4.run(PartRenderingEngine.java:1127)
        at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
        at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1018)
        at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:157)
        at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:654)
        at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:336)
        at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598)
        at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
        at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:139)
        at org.eclipse.test.UITestApplication.runApplication(UITestApplication.java:140)
        at org.eclipse.test.UITestApplication.run(UITestApplication.java:62)
        at org.eclipse.test.UITestApplication.start(UITestApplication.java:212)
        at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:388)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:243)
        at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:669)
        at org.eclipse.equinox.launcher.Main.basicRun(Main.java:608)
        at org.eclipse.equinox.launcher.Main.run(Main.java:1515)
        at org.eclipse.equinox.launcher.Main.main(Main.java:1488)
        at org.eclipse.core.launcher.Main.main(Main.java:34)
    T1 is the main thread

    Concurrent write in thread T155 (locks held: {})
 ---->  at org.eclipse.search2.internal.ui.InternalSearchUI.searchJobFinished(InternalSearchUI.java:114)
        at org.eclipse.search2.internal.ui.InternalSearchUI.access$1(InternalSearchUI.java:113)
        at org.eclipse.search2.internal.ui.InternalSearchUI$1.run(InternalSearchUI.java:230)
        at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:119)
    T155 is created by T1
        at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:386)
}}}
Comment 2 Eclipse Genie CLA 2019-07-19 17:02:29 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.