Community
Participate
Working Groups
I'm sorry but I'm still not familiar with the setup of the performance tests. In Platform UI runtime I have ContextPerformanceTest.java. I would like to migrate that test to JUni 4. Is that supported by our performance test infrastructure? If yes, what do I need to do?
We run them just like the JUnit tests, so shouldn't matter (as far as I know) but the "performance" flag turned on (and performance capturing bundles/fragments installed). If you already have performance tests, just make sure it's part of the suite that's named in the test.xml file. The "performance flag" is what causes our framework to execute the target in your test.xml that looks similar to the following (this example is from org.eclipse.ui.tests.performance) <target name="performance" depends="init,performance-suite,jface-performance-suite,cleanup"> <ant target="collect" antfile="${library-file}" dir="${eclipse-home}"> <property name="includes" value="org*.xml"/> <property name="output-file" value="${plugin-name}.xml"/> </ant> </target> If the code is not yet "instrumented" at all, you will need to read https://wiki.eclipse.org/Performance/Automated_Tests and decide how you want to instrument it. (I'd start off minimally :) HTH
Thanks David.
I don't think this is a releng bug. Or perhaps I misunderstand what Lars asked. Eventually we will have to remove the usage of junit.framework junit 3 type packages (https://wiki.eclipse.org/JUnit4Migration) But the PerformanceTestRunner which gets used by (all of?) the performance tests takes the junit 3 API junit.framework.TestCase in its run methods: org.eclipse.core.tests.harness.PerformanceTestRunner.run(TestCase, String, int, int)
There are similar issues with our session test harness code: org.eclipse.core.tests.session.SessionTestSuite org.eclipse.core.tests.session.SessionTestRunner
Thanks for the clarification and education, Tom. I've been confused about this before. :) (Since "TestCase" is part of JUnit 4 -- I need things spelled out for me -- at least in areas I that I do not follow closely) . So, I do think it is a valid enhancement request since it could be interpreted as meaning provide support for "the new 4.0 (only) JUnit-Style of tests" (if that is the right wording .. if not, please correct the title) And we'll carry forward as that sort of request).
(In reply to Thomas Watson from comment #3) > Eventually we will have to remove the usage of junit.framework junit 3 type > packages (https://wiki.eclipse.org/JUnit4Migration) No, that was false information. Sopot has not given any evidence why JUnit 3 tests wouldn't run in JUnit 5. JUnit 4 includes JUnit 3, so even if JUnit 5 wouldn't include direct support for JUnit 3, those tests could still be run using the JUnit 4 runner. There's no need to migrate any tests.
(In reply to Markus Keller from comment #6) > There's no need to migrate any tests. Except to take advantage of any new functionality in JUnit and to attract contributors, which typically want to use latest and greatest. I had once one student working for me and after I showed him our platform UI JUnit3 tests, he said "these are not test, the annotations are missing". That was my trigger to start migrating the platform UI tests.
