473533 – HTML to Confluence conversion inserts space between adjacent/nested span blocks

Bug 473533 - HTML to Confluence conversion inserts space between adjacent/nested span blocks

Summary: HTML to Confluence conversion inserts space between adjacent/nested span blocks

Status:	RESOLVED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	Mylyn (show other bugs)
Version:	2.6
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	2.6
Assignee:	James Kennedy
QA Contact:	David Green

URL:
Whiteboard:
Keywords:	contributed

Depends on:
Blocks:

Reported:	2015-07-24 13:42 EDT by James Kennedy
Modified:	2015-07-30 19:29 EDT (History)
CC List:	0 users

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description James Kennedy

2015-07-24 13:42:47 EDT

When html "<i>italic</i><b><i>bolditalic</i></b>" is converted to Confluence a space is added between the bold and italic delimeters to get "_italic_ * _bolditalic_*".

The spaces are being introduced because ConfluenceDocumentBuilder.computeSpan() assumes requireAdjacentWhitespace = true for both BOLD and ITALIC types. The way that the code currently inserts those spaces seems to behave badly when ITALIC is nested within BOLD because a space is introduced in between both start prefixes ('*' and '_').

Comment 1 Eclipse Genie

2015-07-24 13:53:17 EDT

New Gerrit change created: https://git.eclipse.org/r/52517

Comment 2 James Kennedy

2015-07-24 13:54:30 EDT

Review with tests showing the issue:
https://git.eclipse.org/r/52517

Comment 3 Eclipse Genie

2015-07-30 19:28:49 EDT

Gerrit change https://git.eclipse.org/r/52517 was merged to [master].
Commit: http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.docs.git/commit/?id=00b8f6fd84e1982f58bbf3621a9dbe74b499ed88

Comment 4 David Green

2015-07-30 19:29:43 EDT

Thanks for the contribution James.