Bug 473184 - Allow user to disable drag and drop of toolbars and tool components
Summary: Allow user to disable drag and drop of toolbars and tool components
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 4.6 M2   Edit
Assignee: Patrik Suzzi CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2015-07-21 08:26 EDT by Nobody - feel free to take it CLA
Modified: 2016-04-04 12:00 EDT (History)
2 users (show)

See Also:

Attachments
Patch containing the fix (3.64 KB, patch)
2015-07-22 19:46 EDT, Patrik Suzzi CLA 		no flags Details | Diff
Img with the section added to N&N (29.34 KB, image/png)
2015-09-03 02:35 EDT, Patrik Suzzi CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nobody - feel free to take it CLA 2015-07-21 08:26:34 EDT 
Originally came out of bug 472761. We need to give provide a way for RCP applications to disable their toolbar drag and drop functionality. One way to do that would be through a tag in the application level.
Comment 1 Lars Vogel CLA 2015-07-21 08:35:05 EDT 
Similar to MPart which allow the NoMove flag, the toolbar should be taggable with IPresentationEngineNoMove and the DnD should disallow moving such tagged toolbars.
Comment 2 Nobody - feel free to take it CLA 2015-07-22 05:02:21 EDT 
Patrik expressed intent to fix this bug. Re-assigning to him.
Comment 3 Patrik Suzzi CLA 2015-07-22 19:46:11 EDT 
Created attachment 255365 [details]
Patch containing the fix

The Gerrit server seems broken, so I'm se1nding a patch that fixes the bug
Comment 4 Lars Vogel CLA 2015-07-23 02:07:41 EDT 
Gerrit looks fine to me, someone uploaded recently a review. What issue do you see?
Comment 5 Eclipse Genie CLA 2015-07-23 03:54:59 EDT 
New Gerrit change created: https://git.eclipse.org/r/52393
Comment 6 Patrik Suzzi CLA 2015-07-23 03:59:53 EDT 
My fault. Gerrit is working fine.
I previously worked and tried to push on master.
Comment 7 Lars Vogel CLA 2015-08-04 05:52:05 EDT 
Patrik, please see the review. This is almost good to go, just one minor thing
Comment 9 Lars Vogel CLA 2015-08-28 10:58:16 EDT 
Thanks Patrik for the patch. Could you also provide a Gerrit review for a Note and Noteworthy entry?
Comment 10 Lars Vogel CLA 2015-08-28 11:09:10 EDT 
.
Comment 11 Eclipse Genie CLA 2015-09-03 02:30:44 EDT 
New Gerrit change created: https://git.eclipse.org/r/55161
Comment 12 Patrik Suzzi CLA 2015-09-03 02:35:49 EDT 
Created attachment 256346 [details]
Img with the section added to N&N

I added a new <tr/> section. see attachment
Comment 13 Patrik Suzzi CLA 2016-04-04 07:26:28 EDT 
There is a Gerrit change pending. Is the N&N merge needed ?
Comment 14 Lars Vogel CLA 2016-04-04 08:03:48 EDT 
(In reply to Patrik Suzzi from comment #13)
> There is a Gerrit change pending. Is the N&N merge needed ?

Looks like we missed that. Can you add it to M7 N&N?
Comment 15 Eclipse Genie CLA 2016-04-04 10:08:13 EDT 
New Gerrit change created: https://git.eclipse.org/r/69828
Comment 16 Patrik Suzzi CLA 2016-04-04 10:10:22 EDT 
Added N&N in M7