Bug 472069 - Show in System Explorer is wrong wording on Mac OS
Summary: Show in System Explorer is wrong wording on Mac OS
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 4.5   Edit
Hardware: Macintosh Mac OS X
: P4 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact: Brian de Alwis CLA
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2015-07-07 11:38 EDT by Michael Coblenz CLA
Modified: 2023-09-01 06:28 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Coblenz CLA 2015-07-07 11:38:04 EDT
"System Explorer" is a confusing name — what is that? Maybe this term is from Windows? On the Mac, this command should be called "Show in Finder".
Comment 1 Brian de Alwis CLA 2015-07-07 12:39:51 EDT
Good point!  I was actually confused by this too.

I can't see any way to support platform-specific label text in the plugin.xml, so I think the only real approach is to have the ShowInSystemExplorerHandler handler implement IElementUpdater.
Comment 2 Andrew Johnson CLA 2023-09-01 06:28:18 EDT
Three ideas:

The plugin text is from plugin.properties
This can be localized if as it is retrieved via code adding $nl$, so plugin_fr_FR.properties. Does the code also try with $os$ ?

Also the menu code is here: https://github.com/eclipse-platform/eclipse.platform.ui/blob/81e7679279080525779750c0415907d7326015b6/bundles/org.eclipse.ui.ide/plugin.xml#L2177-L2192

It might be possible to have two menu contributions, with different labels, and a visibleWhen which has an 'and' and possible 'not' with a 'systemTest' on 'os.name' or possibly another property.
https://wiki.eclipse.org/Platform_Expression_Framework

Eclipse Memory Analyzer has a similar menu item in the Heap Dump History view, but the wording there is 'Open in File System', so would 'Show In' > 'File System' be acceptable to everyone? The file open dialog on Linux has a option on a file for 'Open With File Manager', so 'File Manager' could be a suitable term.