Bug 471154 - Move cell editor, color pickers, and dialogs from MVC.FX.UI to FX.UI, split FX.UI into FX.SWT and FX.JFace
Summary: Move cell editor, color pickers, and dialogs from MVC.FX.UI to FX.UI, split F...
Status: RESOLVED FIXED
Alias: None
Product: GEF
Classification: Tools
Component: GEF MVC (show other bugs)
Version: 0.1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.0.0 / 3.11.0 (Neon) M2   Edit
Assignee: gef-inbox CLA
QA Contact: Alexander Nyßen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 470635
  Show dependency tree
 
Reported: 2015-06-26 12:30 EDT by Alexander Nyßen CLA
Modified: 2015-09-22 05:11 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Nyßen CLA 2015-06-26 12:30:56 EDT 
The cell editor, color picker, and dialog classes located in o.e.gef4.mvc.fx.ui.properties should be moved to FX.UI because they are independent of MVC.
Comment 1 Alexander Nyßen CLA 2015-07-27 13:15:01 EDT 
As FX.UI does currently not provide any JFace or Eclipse UI dependency (but SWT dependencies only), we should combine this with bug #470635.
Comment 2 Alexander Nyßen CLA 2015-09-15 10:30:19 EDT 
I implemented the following changes:

- Merged AbstractFXColorPicker and nested ColorWheel into FXColorPicker. Changed FXColorPicker to be an SWT Composite and refactored it internally.
- Renamed FXSimpleGradientPicker into FXSimpleLinearGradientPicker, changed it to be an SWT Composite, and refactored it internally.
- Renamed FXAdvancedGradientPicker into FXAdvancedLinearGradientPicker, changed it to be an SWT Composite, and refactored it internally.
- Increased versions of MVC.FX.UI bundle and feature to 0.3.0. In consequence adjusted versions of MVC example and doc bundles, as well as enclosing features to 0.3.0.
- Increased versions of clients bundles and features (Zest.FX.UI, DOT.UI) and related test, examples, and sdk bundles/features to 0.3.0.
- Created new org.eclipse.gef4.fx.swt bundle and related feature (both in initial version 0.3.0).
- Created new org.eclipse.gef4.fx.jface bundle and related feature (both in initial version 0.3.0).
- Adjusted FX sdk feature, examples and doc bundles/features accordingly.
- Adjusted version dependencies of related bundles where needed.

I pushed all changes to origin/neon. I will resolve this as soon as we have merged the changes into master.
Comment 3 Alexander Nyßen CLA 2015-09-22 05:11:04 EDT 
Moved FXPaintPropertyDescriptor back to MVC.FX.UI, as it does not seem to be appropriate to have an own bundle for it. Accordingly removed the FX.UI module, so that the FX component now consists of FX, FX.SWT, and FX.JFace modules.

Adjusted wiki documentation and new and noteworthy documents accordingly (we will have to update the component picture, but as Cloudio.UI and Zest.FX.UI will be split as well, this may be postponed after then). 

Resolving as fixed in Neon M2.