Bug 470635 - Consider splitting UI-modules into SWT-/JFace-/UI-modules where appropriate, adjust naming conventions
Summary: Consider splitting UI-modules into SWT-/JFace-/UI-modules where appropriate, ...
Status: RESOLVED FIXED
Alias: None
Product: GEF
Classification: Tools
Component: Misc (show other bugs)
Version: 0.1.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.0.0 / 3.11.0 (Neon) M2   Edit
Assignee: Alexander Nyßen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 468707 470636 471154
Blocks:
  Show dependency tree
 
Reported: 2015-06-20 00:19 EDT by Alexander Nyßen CLA
Modified: 2015-09-25 07:54 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Nyßen CLA 2015-06-20 00:19:38 EDT 
While we currently use the suffix .ui to depict SWT, JFace, as well as Eclipse Workbench UI dependencies, it could make sense to differentiate this on a more fine-grained level. E.g., Cloudio.UI and Zest.UI contain JFace-related parts that do not depend on the Eclipse Workbench UI. 

It would IMHO make sense to factor out these parts into own bundles, using the following naming conventions:

- .swt where only SWT-dependencies exist
- .jface where SWT-/JFace-dependencies exist
- .ui where SWT-/JFace-/UI-dependencies exist

Actually, the GEF4 Geometry.Convert.SWT already uses this convention (and violates our current naming conventions, because it uses SWT instead of UI).
Comment 1 Alexander Nyßen CLA 2015-06-20 00:34:33 EDT 
Factoring out SWT-/JFace-related parts could make sense for Cloudio (bug #468707) and Zest (bug #470636). 

FX.UI should be renamed to FX.SWT if applying the new conventions.
Comment 2 Alexander Nyßen CLA 2015-06-26 12:31:51 EDT 
(In reply to Alexander Nyßen from comment #1)
> Factoring out SWT-/JFace-related parts could make sense for Cloudio (bug
> #468707) and Zest (bug #470636). 
> 
> FX.UI should be renamed to FX.SWT if applying the new conventions.

If we move the cell editor, color pickers, and dialogs from MVC.FX.UI to FX.UI (as outlined in bug #471154), the FX.UI bundle should keep its name or be split into FX.SWT and FX.JFace accordingly.
Comment 3 Alexander Nyßen CLA 2015-09-22 05:26:42 EDT 
Completed the splitting of FX.UI into FX.SWT and FX.JFace as part of bug #471154. What remains is the refactoring of Zest.FX.UI and Cloudio.UI.

After these have been completed, the overview diagram in the wiki doc needs to be adjusted.
Comment 4 Alexander Nyßen CLA 2015-09-25 07:54:09 EDT 
Updated wiki documentation of FX and MVC bundles accordingly. Resolving as fixed in 3.11.0 M2.