Bug 471057 - Error reporting should be disabled in PDE launches
Summary: Error reporting should be disabled in PDE launches
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Recommenders (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: EPP Error Reports CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-25 17:36 EDT by Alex Blewitt CLA
Modified: 2015-09-15 15:00 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Blewitt CLA 2015-06-25 17:36:54 EDT
I'm testing a few PDE launches and the error reporting tool wants to raise errors there as well. I don't think most of those will be appropriate since they're more likely to be in errors I have made, or debug points which I have put in that trigger UI delays. If the error reporter can determine if it's running in PDE then it should automatically disable itself.
Comment 1 Marcel Bruch CLA 2015-06-26 01:56:25 EDT
What exactly is a "PDE launch"? 

If you fire up a normal Eclipse runtime from a running Eclipse, it disables itself because no build-id system property is set. See [1]. This also works for Tycho builds.

We also disable ourself if a system property ‑Dorg.eclipse.epp.logging.aeri.ui.skipReports=true is set. This may help immediately in your case.

When I understand what you call a "PDE launch" we may find a way to automatically detect this. Or do you already have an idea how could we detect this? 






[1] https://git.eclipse.org/c/epp/org.eclipse.epp.logging.git/tree/bundles/org.eclipse.epp.logging.aeri.ui/src/org/eclipse/epp/internal/logging/aeri/ui/log/StatusPredicates.java#n69

[2] https://wiki.eclipse.org/EPP/Logging#Disabling_AERI_in_builds_and_runtime_Eclipse
Comment 2 Alex Blewitt CLA 2015-06-26 02:57:08 EDT
When is this test called? I saw a notification dialog "Enable error reporting" from a launched Eclipse instance, so either this happened before the test is called (maybe from a bad hostnanebtest job) or its being applied too late in the sequence (maybe upon send as opposed to on first notification). 

I'll see if I can work out a simple reproducible test case and verify if the build is set. Running on OSX if that makes a difference.
Comment 3 Andreas Sewe CLA 2015-06-26 03:04:56 EDT
(In reply to Alex Blewitt from comment #2)
> When is this test called? I saw a notification dialog "Enable error
> reporting" from a launched Eclipse instance, so either this happened before
> the test is called (maybe from a bad hostnanebtest job) or its being applied
> too late in the sequence (maybe upon send as opposed to on first
> notification). 

FYI, the status filters are configured in [1] and applied one after the other as soon as an IStatus is logged [2].

[1] <https://git.eclipse.org/c/epp/org.eclipse.epp.logging.git/tree/bundles/org.eclipse.epp.logging.aeri.ui/src/org/eclipse/epp/internal/logging/aeri/ui/Startup.java#n199>
[2] <https://git.eclipse.org/c/epp/org.eclipse.epp.logging.git/tree/bundles/org.eclipse.epp.logging.aeri.ui/src/org/eclipse/epp/internal/logging/aeri/ui/log/LogListener.java#n42>
Comment 4 Alex Blewitt CLA 2015-06-26 04:02:36 EDT
Ok I'll do some further debugging and see if I can reproduce the problem.