Bug 470723 - run jdeps -jdkinternals
Summary: run jdeps -jdkinternals
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.7 M4   Edit
Assignee: Sravan Kumar Lakkimsetti CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 509572
  Show dependency tree
 
Reported: 2015-06-22 10:41 EDT by Dani Megert CLA
Modified: 2016-12-21 06:05 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2015-06-22 10:41:02 EDT 
4.5.

In order to prepare for Java 9 we need to check whether we use JDK internal code.

This can be done by running jdeps -jdkinternals on our code.
Comment 1 David Williams CLA 2015-06-22 13:23:02 EDT 
And ... this should be a cross-project bug too, right? :) 

[I think I did run it informally at one point, and all looked clear, but, would be best to run as unit test, of some sort.] 

If I understand it right, this can be ran from a repository's plugin directory with this sort of command: 

/shared/common/jdk1.8.0_x64-latest/bin/jdeps -classpath ${PWD} -jdkinternals

and if that's accurate, both ours, and the Sim. Release repo look clear. 

(that is, no output was produced .. not sure if thats means "no problems found" or "no classes found" :(
Comment 2 David Williams CLA 2015-06-22 14:14:46 EDT 
(In reply to David Williams from comment #1)
> (that is, no output was produced .. not sure if thats means "no problems
> found" or "no classes found" :(

Pretty sure that means no classes found. 

I think the way it is supposed to be ran is with an asterisk at end (classes, at end), such as 

${JAVA_HOME}/bin/jdeps -classpath ${JAVA_HOME}/lib/tools.jar:${PWD} -jdkinternals *

But, perhaps a bug in this version on build machine, since above command results in 

Exception in thread "main" java.lang.InternalError: Missing message: warn.skipped.entry
        at com.sun.tools.jdeps.JdepsTask.getMessage(JdepsTask.java:694)
        at com.sun.tools.jdeps.JdepsTask.warning(JdepsTask.java:658)
        at com.sun.tools.jdeps.JdepsTask.findDependencies(JdepsTask.java:551)
        at com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:324)
        at com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:306)
        at com.sun.tools.jdeps.Main.main(Main.java:48)
Comment 3 Dani Megert CLA 2015-06-24 08:24:39 EDT 
(In reply to David Williams from comment #1)
> And ... this should be a cross-project bug too, right? :) 

Right, but I thought we first do it on Platform and then open a bug with steps on how exactly run the tool to get the results.
Comment 4 David Williams CLA 2015-10-21 10:52:48 EDT 
Untargeting for specific milestone, since not sure which milestone I'll finish this in.
Comment 5 Sravan Kumar Lakkimsetti CLA 2016-10-25 05:32:36 EDT 
moving to M4
Comment 6 Eclipse Genie CLA 2016-11-24 07:06:28 EST 
New Gerrit change created: https://git.eclipse.org/r/85682
Comment 7 Sravan Kumar Lakkimsetti CLA 2016-11-24 07:26:56 EST 
(In reply to Eclipse Genie from comment #6)
> New Gerrit change created: https://git.eclipse.org/r/85682

Donot push before Dec 1, 2016. This change will impact 4.6.2 build
Comment 9 Sravan Kumar Lakkimsetti CLA 2016-11-30 23:55:12 EST 
(In reply to Eclipse Genie from comment #8)
> Gerrit change https://git.eclipse.org/r/85682 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/
> commit/?id=5d259deae5b7b433e02a6df48eed8a75a9f04b3a

In master now
Comment 10 David Williams CLA 2016-12-01 10:35:44 EST 
(In reply to Sravan Kumar Lakkimsetti from comment #9)
> (In reply to Eclipse Genie from comment #8)
> > Gerrit change https://git.eclipse.org/r/85682 was merged to [master].
> > Commit:
> > http://git.eclipse.org/c/platform/eclipse.platform.releng.aggregator.git/
> > commit/?id=5d259deae5b7b433e02a6df48eed8a75a9f04b3a
> 
> In master now

I've not even looked, but are the results easy to find?
Comment 11 Sravan Kumar Lakkimsetti CLA 2016-12-02 00:13:24 EST 
Its part of release engineering build logs

example report http://download.eclipse.org/eclipse/downloads/drops4/I20161201-2000/buildlogs/jdepsReport.txt
Comment 12 Sravan Kumar Lakkimsetti CLA 2016-12-05 04:42:36 EST 
The jdeps -jdkinternals report is getting generated on every build.
Comment 13 Dani Megert CLA 2016-12-06 11:56:56 EST 
(In reply to Sravan Kumar Lakkimsetti from comment #11)
> Its part of release engineering build logs
> 
> example report
> http://download.eclipse.org/eclipse/downloads/drops4/I20161201-2000/buildlogs/jdepsReport.txt
> 

Has

Exception in thread "main" java.lang.InternalError: Missing message: warn.skipped.entry
	at com.sun.tools.jdeps.JdepsTask.getMessage(JdepsTask.java:702)
	at com.sun.tools.jdeps.JdepsTask.warning(JdepsTask.java:666)
	at com.sun.tools.jdeps.JdepsTask.findDependencies(JdepsTask.java:556)
	at com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:324)
	at com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:306)
	at com.sun.tools.jdeps.Main.main(Main.java:48)
Comment 14 Sravan Kumar Lakkimsetti CLA 2016-12-07 01:27:48 EST 
(In reply to Dani Megert from comment #13)
> (In reply to Sravan Kumar Lakkimsetti from comment #11)
> > Its part of release engineering build logs
> > 
> > example report
> > http://download.eclipse.org/eclipse/downloads/drops4/I20161201-2000/buildlogs/jdepsReport.txt
> > 
> 
> Has
> 
> Exception in thread "main" java.lang.InternalError: Missing message:
> warn.skipped.entry
> 	at com.sun.tools.jdeps.JdepsTask.getMessage(JdepsTask.java:702)
> 	at com.sun.tools.jdeps.JdepsTask.warning(JdepsTask.java:666)
> 	at com.sun.tools.jdeps.JdepsTask.findDependencies(JdepsTask.java:556)
> 	at com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:324)
> 	at com.sun.tools.jdeps.JdepsTask.run(JdepsTask.java:306)
> 	at com.sun.tools.jdeps.Main.main(Main.java:48)

This is a bug in JDK https://bugs.openjdk.java.net/browse/JDK-8167014. I will suppress this error next build