Bug 470700 - Request to change the DocumentMerger.Diff constructor to protected
Summary: Request to change the DocumentMerger.Diff constructor to protected
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 4.3.2   Edit
Hardware: PC Mac OS X
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-22 08:04 EDT by Joseph Benavides CLA
Modified: 2015-06-22 11:31 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Benavides CLA 2015-06-22 08:04:41 EDT 
We are currently experimenting on leveraging the TextMergeViewer for our purpose.  We are looking to reuse what's existing to use for our own type of compare viewer but we needed to make some changes to our own subclassed DocumentMerger class to only compare a certain region in the files while still displaying the entire file contents. Similar to what a clone compare viewer would do.  

While we have already able to subclass the DocumentMerger file, we are unable to subclass the Diff class due to its constructor being package visible.  We were able to work our way around this via reflection but it would be better if we didn't have to.

Therefore we would like to propose to change the DocumentMerger.Diff constructor be made protected.

We are aware though that this is an internal class and any future updates might or will certainly break our code but that is something that are aware and are ok with.


cheers!

Joseph