Community
Participate
Working Groups
Created attachment 254560 [details] Expressions are being hidden away by ellipses, even if there is enough room to fit all expressions. In the Expressions view in Eclipse, no matter how wide the view is, it will always hide away long expressions with ellipses. This is unnecessary, especially when I need to use the expressions I type in to determine what was wrong with the data. I have attached a snapshot of the Expressions view hiding away expressions with ellipses, using a few expressions as examples. In reality, I would have tens of the expressions, all of which I need to look over them as I debug my way through. It's worth noting that my monitor is 1080p, there's just way too much empty space that the Expressions view can utilize.
Changing this from Debug to UI, as it's more of a UI problem. Sorry about that.
Sarika, please check whether this is Debug or Platform UI.
Looks Like Debug issue.
Hello, it's the first day of year 2017. Has this issue been resolved?
Created attachment 266081 [details] This is still an issue in Eclipse Neon 4.6.0, Build ID: 20160613-1800. Maybe there are changes?
(In reply to Taro Kyo from comment #4) > Hello, it's the first day of year 2017. Has this issue been resolved? Unfortunately, no one is working on this issue. If someone can provide a good quality patch, we can look at it.
The root cause of this bug lies in the getWatchExpressionName() method in org.eclipse.debug.internal.ui.model.elements.ExpressionLabelProvider. There is a hard coded 30 characters limit for the expression Name. I think on the very big monitors today this limit makes no sense anymore. There are some possible solutions for this problem. 1. Remove the limit completely and let SWT limit the text in the table cell. 2. Lift the limit to 256 characters because this is the maximum value a table column can view properly in Windows (other platforms have higher limits so should be no problem with them) 3. Make the limit configurable in the preferences of Debug. I can provide a patch on gerrit, but it will be really nice if anyone with commit rights in the debug project will tell me which solution i should create, because i do not want to spend time on a patch which will never be committed.
(In reply to Ralf Petter from comment #7) > The root cause of this bug lies in the getWatchExpressionName() method in > org.eclipse.debug.internal.ui.model.elements.ExpressionLabelProvider. There > is a hard coded 30 characters limit for the expression Name. I think on the > very big monitors today this limit makes no sense anymore. > > There are some possible solutions for this problem. > > 1. Remove the limit completely and let SWT limit the text in the table cell. On older GTK 2/3 versions huge text/table widgets size could lead to unpredictable results up to UI freeze. > 2. Lift the limit to 256 characters because this is the maximum value a > table column can view properly in Windows (other platforms have higher > limits so should be no problem with them) Please do this. The change would be small & I could merge this without fear to break something. > 3. Make the limit configurable in the preferences of Debug. Nice to have. > I can provide a patch on gerrit, but it will be really nice if anyone with > commit rights in the debug project will tell me which solution i should > create, because i do not want to spend time on a patch which will never be > committed. Thank you to step in!
New Gerrit change created: https://git.eclipse.org/r/88263
Hm looks like the source of ExpressionLabelProvider is indented using whitespace characters and not using tabs. Is this a problem? I can reconfigure my eclipse editor to use whitespace and upload a new patch set if this is needed. Would be really nice, if all eclipse projects would have the same formatting policy.
(In reply to Ralf Petter from comment #10) > Hm looks like the source of ExpressionLabelProvider is indented using > whitespace characters and not using tabs. Is this a problem? I can > reconfigure my eclipse editor to use whitespace and upload a new patch set > if this is needed. > > Would be really nice, if all eclipse projects would have the same formatting > policy. The org.eclipse.debug.ui project preferences are set to use tabs, the code historically seem to use spaces, and the current code is a happy mix of both, so I would not care in your case. However (and I guess I will be in minority here) I would prefer to clean the whitespace issues in org.eclipse.debug.ui by: 1) Remove all trailing white space 2) Add preference to run save action to cleanup white space on save 3) Convert all code to use tabs @Dani, Markus: I guess you have objections to 3), but what about 1) and 2)?
Gerrit change https://git.eclipse.org/r/88263 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=0548d360ff223dcd7dcde4ee0650a56c0807a2c3
Thanks Ralf! I think your smallest possible patch fixes the issue for most users, entering/viewing an expression longer then 254 characters is not of a fun anymore anyway.
Created attachment 266198 [details] Example of an expression before and after this fix is applied
Verified using Eclipse SDK Version: Oxygen (4.7) Build id: I20170123-2000
