Bug 468700 - move Mylyn notifications preference page to General category
Summary: move Mylyn notifications preference page to General category
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 8
: P3 normal (vote)
Target Milestone: 3.16   Edit
Assignee: Frank Becker CLA
QA Contact: Steffen Pingel CLA
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2015-05-28 14:45 EDT by Stephan Eberle CLA
Modified: 2015-06-03 11:52 EDT (History)
4 users (show)

See Also:


Attachments
mylyn/context/zip (4.13 KB, application/octet-stream)
2015-05-28 16:06 EDT, Frank Becker CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Eberle CLA 2015-05-28 14:45:08 EDT
In the Eclipse Automotive IDE package, only the following Mylyn plug-ins get installed:

* org.eclipse.mylyn.commons.core
* org.eclipse.mylyn.commons.notifications.core
* org.eclipse.mylyn.commons.notifications.ui
* org.eclipse.mylyn.commons.screenshots
* org.eclipse.mylyn.commons.ui
* org.eclipse.mylyn.commons.workbench

When starting it, we get the following warning in the Error Log view:

Invalid preference category path: org.eclipse.mylyn.preferencePages.Mylyn (bundle: org.eclipse.mylyn.commons.notifications.ui, page: org.eclipse.mylyn.commons.notifications.preferencePages.Notifications)

We suggest to either rework the plug-in dependencies of the org.eclipse.mylyn.commons.notifications.ui such that the contributor of the missing preference category gets pulled in by p2, or to move/reorganize the Mylyn preference categories to avoid this warning.
Comment 1 Marcel Bruch CLA 2015-05-28 15:22:29 EDT
This log message is caused by the error reporting which pulls-in these bundles (see the  related thread on epp-dev).

I'm not sure how this can be fixed ATM. Automotive is one of two packages that does not include Mylyn. Thus, you get this log message.

Note that there is work in progress moving Mylyn Notifications to the platform. But this is won't happen for Mars SR0.
Comment 2 Frank Becker CLA 2015-05-28 16:06:51 EDT
I think we need to move org.eclipse.mylyn.internal.tasks.ui.preferences.MylynPreferencePage to org.eclipse.mylyn.commons.ui.MylynPreferencePage and change the definition in plugin.xml.

Thoughts?
Comment 3 Frank Becker CLA 2015-05-28 16:06:54 EDT
Created attachment 253914 [details]
mylyn/context/zip
Comment 4 Sam Davis CLA 2015-05-28 17:02:27 EDT
(In reply to comment #1)
> Note that there is work in progress moving Mylyn Notifications to the platform.

This is news to me...

(In reply to comment #2)
> I think we need to move
> org.eclipse.mylyn.internal.tasks.ui.preferences.MylynPreferencePage to
> org.eclipse.mylyn.commons.ui.MylynPreferencePage and change the definition in
> plugin.xml.
> 
> Thoughts?

That seems to make sense to me. We could also or instead consider moving the Notifications preference page to the top level since it can be contributed to by any plugin.
Comment 5 Marcel Bruch CLA 2015-05-28 17:23:25 EDT
(In reply to Sam Davis from comment #4)
> (In reply to comment #1)
> > Note that there is work in progress moving Mylyn Notifications to the platform.
> 
> This is news to me...

I take my knowledge from bug 467038 and referenced bugs/emails. If there was yet no conversation this might happen soon - or not... FWIW, I'm not involved.
Comment 6 Sam Davis CLA 2015-05-28 17:40:58 EDT
Thanks. It doesn't look to me like there is actually any work in progress, yet. AFAIK no Mylyn Commons committer has had any discussions about this in recent years.
Comment 7 Gunnar Wagenknecht CLA 2015-05-29 03:14:49 EDT
I'm not sure what the outcome will be. Frankly, I would expect that this new framework would live in a package namespace of Eclipse Platform UI and thus, requires migration.

Anyway, I don't think we should introduce a common Mylyn preference category. Instead, I'd prefer to contribute the Notifications preference page to the "General" category. It's applicable globally.

That change should be mentioned in a N&N.
Comment 8 Marcel Bruch CLA 2015-05-29 03:26:17 EDT
(In reply to Gunnar Wagenknecht from comment #7)
> Instead, I'd prefer to contribute the Notifications preference
> page to the "General" category. It's applicable globally.


+1 (without thinking about which implication this may have for Mylyn users who know where to look)
Comment 9 Stephan Eberle CLA 2015-05-29 07:46:46 EDT
(In reply to Marcel Bruch from comment #8)
> (In reply to Gunnar Wagenknecht from comment #7)
> > Instead, I'd prefer to contribute the Notifications preference
> > page to the "General" category. It's applicable globally.
> 
> 
> +1 (without thinking about which implication this may have for Mylyn users
> who know where to look)

+1 from my side as well - this would actually prepare the UI for intended transfer of Mylyn Notifications to the platform.
Comment 10 Frank Becker CLA 2015-05-29 16:25:55 EDT
create review https://git.eclipse.org/r/#/c/49004/ for the common part

and review https://git.eclipse.org/r/#/c/49005/ for the changes in o.e.m.tasks
Comment 11 Sam Davis CLA 2015-06-02 18:46:30 EDT
Thanks Frank. It seems like a good idea to do this for Mars.
Comment 12 Sam Davis CLA 2015-06-02 19:45:07 EDT
The changes have been merged.