Bug 467914 - mediawiki-to-eclipse-help does not properly handle stylesheet urls that do not point to files.
Summary: mediawiki-to-eclipse-help does not properly handle stylesheet urls that do no...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 2.4   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: David Green CLA
QA Contact: David Green CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 467060
  Show dependency tree
 
Reported: 2015-05-21 15:53 EDT by Alexander Nyßen CLA
Modified: 2015-06-05 16:02 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Nyßen CLA 2015-05-21 15:53:22 EDT 
When using a stylesheet url that refers to an http or https url, this is not correctly interpreted by the mediawiki-to-eclipse-help task. That is, if generating help documentation with the following setup

<stylesheet url="http://wiki.eclipse.org/skins/solstice/public/stylesheets/styles.min.css?303" />

the following stylesheet entry is generated into the doc html files. 

<link type="text/css" rel="stylesheet" href="../../../http://wiki.eclipse.org/skins/solstice/public/stylesheets/styles.min.css?303"/>

It does always seem to interpret the url as a file path. I would expect that URLs are properly handled (and that a file url would actually have to be specified as file://)
Comment 1 David Green CLA 2015-06-01 10:17:25 EDT 
Thanks for the bug.  The stylesheet URL is currently interpreted as a relative path, however it makes sense to me that absolute URLs would be accepted.
Comment 2 David Green CLA 2015-06-01 10:28:43 EDT 
  https://git.eclipse.org/r/49095
Comment 3 David Green CLA 2015-06-02 15:13:45 EDT 
review merged, absolute URLs should now be accepted.
Comment 4 Alexander Nyßen CLA 2015-06-03 02:35:17 EDT 
Thanks. Is there a build I could consume for testing purposes?
Comment 5 Alexander Nyßen CLA 2015-06-03 06:36:51 EDT 
(In reply to Alexander Nyßen from comment #4)
> Thanks. Is there a build I could consume for testing purposes?

Think I got it: http://download.eclipse.org/mylyn/snapshots/nightly/docs/
Comment 6 Alexander Nyßen CLA 2015-06-03 06:53:22 EDT 
(In reply to Alexander Nyßen from comment #5)
> (In reply to Alexander Nyßen from comment #4)
> > Thanks. Is there a build I could consume for testing purposes?
> 
> Think I got it: http://download.eclipse.org/mylyn/snapshots/nightly/docs/

Not quite, the last build available is from 20150522-1430 and it does not contain the fix.
Comment 7 David Green CLA 2015-06-05 13:59:07 EDT 
Looks like the review didn't get merged. https://git.eclipse.org/r/#/c/49095/

Unfortunately this didn't make the release, but it will be available via a snapshot build shortly.
Comment 8 David Green CLA 2015-06-05 16:02:28 EDT 
This is now merged, and the latest snapshot is available here: https://www.eclipse.org/downloads/download.php?file=/mylyn/snapshots/nightly/docs/wikitext-standalone-latest.zip