Bug 466991 - Add a test for split packages with different certificates
Summary: Add a test for split packages with different certificates
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 normal with 2 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform-Releng-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-11 08:20 EDT by Dani Megert CLA
Modified: 2021-05-02 16:56 EDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2015-05-11 08:20:39 EDT
Add a test for split packages with different certificates.
Comment 1 Ed Willink CLA 2015-05-11 13:58:33 EDT
Suggestion to avoid dependencies on build details and so allow implementation in the ManifestBuilder; use the greater than 7 day separation between milestones / RCs.

The last touched date of a MANIFEST.MF for a split package must be at most seven days older than the last touched date of any file in the plugins of the other split packages.
Comment 2 Dani Megert CLA 2015-05-11 15:40:27 EDT
(In reply to Ed Willink from comment #1)
> Suggestion to avoid dependencies on build details and so allow
> implementation in the ManifestBuilder; use the greater than 7 day separation
> between milestones / RCs.
> 
> The last touched date of a MANIFEST.MF for a split package must be at most
> seven days older than the last touched date of any file in the plugins of
> the other split packages.

Not sure what this is about. Each I-build can make the check in its own. N-builds are not relevant as those aren't signed.
Comment 3 Ed Willink CLA 2015-05-11 16:21:46 EDT
(In reply to Dani Megert from comment #2)
> (In reply to Ed Willink from comment #1)
> > Suggestion to avoid dependencies on build details and so allow
> Not sure what this is about. Each I-build can make the check in its own.
> N-builds are not relevant as those aren't signed.

I-build tests detect a problem during build so there is potentially a 24 hour delay between offending commit and detection, and of course a failed I-build.

A ManifestBuilder detection will probably detect the problem within 5 minutes, if not 5 seconds. No I-build failure.
Comment 4 Dani Megert CLA 2015-05-12 02:50:14 EDT
(In reply to Ed Willink from comment #3)
> (In reply to Dani Megert from comment #2)
> > (In reply to Ed Willink from comment #1)
> > > Suggestion to avoid dependencies on build details and so allow
> > Not sure what this is about. Each I-build can make the check in its own.
> > N-builds are not relevant as those aren't signed.
> 
> I-build tests detect a problem during build so there is potentially a 24
> hour delay between offending commit and detection, and of course a failed
> I-build.
> 
> A ManifestBuilder detection will probably detect the problem within 5
> minutes, if not 5 seconds. No I-build failure.

It's not that easy because
- there is only a problem when the certificates mismatch. For that the builder
  would have to get the current certificate somehow.
- In order to give accurate results the workspace would have to always be
  updated to the latest I-build.
Comment 5 Ed Willink CLA 2015-05-12 03:01:53 EDT
(In reply to Dani Megert from comment #4)
> - there is only a problem when the certificates mismatch. For that the

True and getting the certificate(s) is very hard from an interactive workspace..

But also the problem only exists for the undesirable practice of split packages, so making split packages 'suffer' by requiring co-MANIFEST.MF touching does not seem to be a terrible imposition to me.
Comment 6 David Williams CLA 2016-08-11 15:26:06 EDT
Doing a mass "reset to default assignee" of 52 bugs to help make clear it will (very likely) not be me working on things I had previously planned to work on. I hope this will help prevent the bugs from "getting lost" in other people's queries. Feel free to "take" a bug if appropriate.
Comment 7 Sravan Kumar Lakkimsetti CLA 2017-05-25 07:07:32 EDT
We will investigate this in 4.8
Comment 8 Ed Willink CLA 2018-07-02 03:32:54 EDT
Bug 536445 reports a new horror whereby split packages were referenced wirth inadequately tight version bounds thereby allowing careless user version dependencies in Maven builds to mix-and-match their resolutions and get a signer failyure rather than the 'correct' incompatible versions.

Please ensure that split packages are tested for tight version cross-dependencies.
Comment 9 Sravan Kumar Lakkimsetti CLA 2018-08-23 02:47:40 EDT
There are plans for this. Will revisit in 4.10
Comment 10 Sravan Kumar Lakkimsetti CLA 2018-12-04 07:09:50 EST
Moving out of 4.10. Please re triage appropriately
Comment 11 Dani Megert CLA 2018-12-04 09:55:33 EST
This one is causing grief, so, should try to resolve for 4.11.
Comment 12 Sravan Kumar Lakkimsetti CLA 2019-02-19 00:19:03 EST
@Kalyan,

Any update on this? If not please move it out of 4.11
Comment 13 Sravan Kumar Lakkimsetti CLA 2019-06-03 23:51:58 EDT
There are no plans for this now. Removing target
Comment 14 Ed Willink CLA 2021-05-02 16:56:10 EDT
Occurs yet again as Bug 573306.