Community
Participate
Working Groups
It would be nice to have a 'Select All' and 'Deselect All' button on the wizard page for selecting the resources to add to your working set.
Just out of curiousity, is there any way this can be contained in the 3.1 release? I would consider this a small usability part of the "Scaling Up" theme for the 3.1 release (bug 71128) as it was reported to myself (via an IBM customer) in this regards. This customer has many projects in their workspace and in some situations would rather 'select all' projects and then deselect individual projects to create a working set. Thanks very much!
MvM, what do you think? This is a pretty small fix.
Troy, any patches with this fix would really go a long way in seeing it happen for 3.1, otherwise I doubt it.
Thanks Michael. Could you provide me some pointers as to which class[es] I would need to look into to add these two buttons?
Sure, have a look at the following: WorkingSetNewWizard (the actual wizard that adds a page for selecting resources) WorkingSetTypePage (the wizard page, see create* methods)
Hi Michael, I've looked over the code and WorkingSetTypePage isn't the place that this would need to be added (this is just the first page of the wizard) but rather it would need to be added to each contributors WorkingSetPage (i.e. JavaWorkingSetPage, ResourceWorkingSetPage, PluginWorkingSet, and BreakpointWorkingSetPage). I don't mind doing this, but it seems like a lot of duplicated code - wouldn't it be better to have a super class that all these classes extend (i.e. a base class) and it would implement a lot of the UI code, while each contributors would extend it and set their corresponding providers, labels, etc.? Right now it seems that each contributor creates their own class which extends WizardPage and implements IWorkingSetPage, and then they implements their own UI code even though all working set edit pages are all the same... just with different providers and labels. Anyway, I just wanted to get your feedback on this... maybe I'm looking at this all wrong - I don't know the history behind the code ;). Also, I'm guessing it may be to late to do this now... if that is the case then I'll look into adding the buttons to each class file (JavaWorkingSetPage, ResourceWorkingSetPage, PluginWorkingSet, and BreakpointWorkingSetPage). Thanks!
I create bug 93654 for the fix to be added to the JavaWorkingSetPage class and bug 93686 for the fix to be added to the BreakpointWorkingSetPage class. I will add the fix to this bug for the ResourceWorkingSetPage class.
Created attachment 20705 [details] ResourceWorkingSetPage.java patch
Created attachment 20706 [details] messages.properties patch
Created attachment 20707 [details] IDEWorkbenchMessages.java patch
For all of the other working set pages, I updated their classes to call: SWTUtil.setButtonDimensionHint(button) after the button is created to ensure that the width of the button is set properly. This class does not seem to exist for the org.eclipse.ui.ide plug-in so I was wondering if you have any suggestions as to how to fix this?
kim, can you review this post M7?
I can. Can you bring this up in the polish meetings for other teams to investigate?
Patch submitted with some alterations. I've applied the dialog font to the new buttons and ensured that setButtonLayoutData() was called.
Troy: instead of calling SWTUtil, you should probably have just called WizardPage.setButtonLayoutData() - that's the standard way of ensuring button layout. You might want to update the other patches to reflect this...
BTW - thanks for your contribution Troy
Thanks a lot Kim.
