Comment 1 Andreas Sewe 2015-06-01 10:18:32 EDT

(In reply to Marcel Bruch from comment #0)
> Subwords cannot properly highlight proposals that have a prefix like {@link
> ...}, {@value ...}.  We need some kind of offset in the processable proposal
> API to fix that.

Some thoughts on this that came up while fixing Bug 465898:

- Javadoc tag proposals are just ordinary JavaCompletionProposal, but they do have a special kind (JAVADOC_INLINE_TAG, etc.), so we can distinguish them.

- When completing with a prefix of "{@" you get the proposal "{@link}" (already highlighted correctly).

- When completing with a prefix of "L" you get the the proposal "{@link List}" (highlighting off by 7)

Comment 2 Andreas Sewe 2015-06-01 14:03:32 EDT

(In reply to Andreas Sewe from comment #1)
> (In reply to Marcel Bruch from comment #0)
> > Subwords cannot properly highlight proposals that have a prefix like {@link
> > ...}, {@value ...}.  We need some kind of offset in the processable proposal
> > API to fix that.
> 
> Some thoughts on this that came up while fixing Bug 465898:
> 
> - Javadoc tag proposals are just ordinary JavaCompletionProposal, but they
> do have a special kind (JAVADOC_INLINE_TAG, etc.), so we can distinguish
> them.
> 
> - When completing with a prefix of "{@" you get the proposal "{@link}"
> (already highlighted correctly).
> 
> - When completing with a prefix of "L" you get the the proposal "{@link
> List}" (highlighting off by 7)

The situation is slightly tricker for method or field proposals of the form

  {@link Collections#emptyList()}

or

  {@value Collections#EMPTY_LIST}

as their matching area starts at a variable offset.

I have pushed a change to Gerrit that should cover these cases, though [1]. Of course, this requires some careful testing.

[1] <https://git.eclipse.org/r/#/c/49124/>

Comment 3 Johannes Dorn 2015-06-02 14:23:03 EDT

Change is merged