Bug 465732 - ToolControl not rendered correctly in Toolbar
Summary: ToolControl not rendered correctly in Toolbar
Status: CLOSED DUPLICATE of bug 471313
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Windows 7
: P3 normal with 2 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 562099 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-04-28 15:41 EDT by Dirk Fauth CLA
Modified: 2020-06-10 09:25 EDT (History)
5 users (show)

See Also:


Attachments
screenshot1 (33.85 KB, image/png)
2015-04-28 15:41 EDT, Dirk Fauth CLA
no flags Details
screenshot2 (28.66 KB, image/png)
2015-04-28 15:41 EDT, Dirk Fauth CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Fauth CLA 2015-04-28 15:41:01 EDT
I added a ToolControl in a Toolbar of the top window trim like this:

    <trimBars xmi:id="_uPMeMLkVEeSwHehsjuW-dw" elementId="de.codecentric.eclipse.tutorial.app.trimbar.0">
      <children xsi:type="menu:ToolBar" xmi:id="_1n-poLkVEeSwHehsjuW-dw" elementId="de.codecentric.eclipse.tutorial.app.toolbar.1">
        <children xsi:type="menu:ToolControl" xmi:id="_7-GeMLkVEeSwHehsjuW-dw" elementId="de.codecentric.eclipse.tutorial.app.toolcontrol.0" contributionURI="bundleclass://de.codecentric.eclipse.tutorial.app/de.codecentric.eclipse.tutorial.app.control.PerspectiveSwitcher"/>
      </children>
    </trimBars>


In 4.4. this looked like screenshot 1.

With the latest Mars integration prior M7 the buttons are not rendered correctly anymore (screenshot 2).
Comment 1 Dirk Fauth CLA 2015-04-28 15:41:24 EDT
Created attachment 252861 [details]
screenshot1
Comment 2 Dirk Fauth CLA 2015-04-28 15:41:49 EDT
Created attachment 252862 [details]
screenshot2
Comment 3 Andrey Loskutov CLA 2015-05-03 18:10:22 EDT
Dirk, can you please check if bug 466233 and proposed fix https://git.eclipse.org/r/46994 is related & fixes your issue?
Comment 4 Dirk Fauth CLA 2015-05-05 15:17:20 EDT
(In reply to Andrey Loskutov from comment #3)
> Dirk, can you please check if bug 466233 and proposed fix
> https://git.eclipse.org/r/46994 is related & fixes your issue?

No that ticket and the proposed fix doesn't have any effect on this issue.
Comment 5 Torsten Kammer CLA 2015-05-29 07:07:00 EDT
I encountered the same problem. It seems to appear only if the ToolControl is the first element in the toolbar. Adding a DirectToolItem or HandledToolItem as first element in the toolbar fixes that issue for me, as of RC2. Using a direct tool item with no handler and a non-breaking space as label, this is almost invisible (but will still show up when hovering over it, of course).
Comment 6 Rolf Theunissen CLA 2020-06-04 15:03:07 EDT
*** Bug 562099 has been marked as a duplicate of this bug. ***
Comment 7 Rolf Theunissen CLA 2020-06-10 09:25:51 EDT

*** This bug has been marked as a duplicate of bug 471313 ***