Community
Participate
Working Groups
Browser test failure with XULR 1.9 on Linux. http://download.eclipse.org/eclipse/downloads/drops4/I20150427-0800/testresults/html/org.eclipse.swt.tests_linux.gtk.x86_64_8.0.html
The tests pass for me locally on RHEL 6.6 and XULRunner 1.9.1.19 and XULRunner 1.9.2. The only difference is I'm using XULRunner 32 bit and the test machine uses XULRunner 64 bit. I don't have any machine with XULR 1.9.1.* 64 bit and it is not available as a download. AFAIK it only comes bundled with old linux distributions.
Browser Tests 1,5,6,8 and 9 are currently failing. These tests were disabled long ago for SWT.MOZILLA style browser on GTK since they were consistently failing on the build machine. The commit in https://bugs.eclipse.org/bugs/show_bug.cgi?id=423561#c49 modified the Mozilla check to a Mozilla Version check and these tests are not supposed to run.
Hi Dani, Looks like the XULRunner on the test machine has been updated to 1.9.2. (please see -- https://bugs.eclipse.org/bugs/show_bug.cgi?id=423561#c51). So, the version checks need to be updated too. I will make the required changes in the tests. Should we push this for M7 or do it post M7?
(In reply to Lakshmi Shanmugam from comment #3) > Hi Dani, > Looks like the XULRunner on the test machine has been updated to 1.9.2. > (please see -- https://bugs.eclipse.org/bugs/show_bug.cgi?id=423561#c51). > So, the version checks need to be updated too. I will make the required > changes in the tests. > Should we push this for M7 or do it post M7? M7 is fine. I assume we'll have a rebuild anyway.
(In reply to Lakshmi Shanmugam from comment #3) > Hi Dani, > Looks like the XULRunner on the test machine has been updated to 1.9.2. > (please see -- https://bugs.eclipse.org/bugs/show_bug.cgi?id=423561#c51). > So, the version checks need to be updated too. I will make the required > changes in the tests. Modified the version check to check for XULR 1.9.2 or before > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=047e1c87f9f536f7e3287259e13c4331a5a65e1d This would disable Tests 1,5 and 6. I've not disabled tests 8 & 9. They have not been failing for a sometime now, will see the test results in the next build and disable them if required.
The test failures should be gone in the M7 rebuild, need to be verified.
Looks like the new xulrunner version on the test machine is quite special. With master and with isProblematicGtkXulRunner set to false, xulrunner 1.9.2.19 and 3.6.28 are green for me, while 10.0.4esr, 24.0, and 31.0 all crash (bug 423561). Given that MozillaVersion.GetCurrentVersion() is not enough to tell if tests are going to fail or not, I think the test should just try to find out whether it's running on the build machine and skip known failing tests there. E.g. by testing "hudsonbuild".equals(System.getProperty("user.name")).
(In reply to Markus Keller from comment #7) > I think the test should just try to find out > whether it's running on the build machine and skip known failing tests there. Done that with http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=2068ee483466223122bf2e333b0d8bb2827b0b93
Verified in I20150504-2000.
