Bug 465711 - Rendering of tabs when hovering using a dark theme makes tab unreadable (CTabRendering)
Summary: Rendering of tabs when hovering using a dark theme makes tab unreadable (CTab...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Windows NT
: P3 normal (vote)
Target Milestone: 4.5 M7   Edit
Assignee: Fabio Zadrozny CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatfix
Depends on:
Blocks:
 
Reported: 2015-04-28 12:45 EDT by Fabio Zadrozny CLA
Modified: 2015-05-16 07:02 EDT (History)
2 users (show)

See Also:


Attachments
Picture showing issue (12.13 KB, image/png)
2015-04-28 12:45 EDT, Fabio Zadrozny CLA
no flags Details
Picture with the patch applied (13.25 KB, image/png)
2015-04-28 13:29 EDT, Fabio Zadrozny CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Zadrozny CLA 2015-04-28 12:45:55 EDT
Created attachment 252857 [details]
Picture showing issue

I'm attaching a screenshot with the issue.

The problem seems to be that org.eclipse.e4.ui.workbench.renderers.swt.CTabRendering.drawUnselectedTab(int, GC, Rectangle, int) has a hardcoded gc.setBackground(gc.getDevice().getSystemColor(SWT.COLOR_WHITE)).

I'll see if I can come up with a patch for M7.
Comment 1 Eclipse Genie CLA 2015-04-28 13:26:38 EDT
New Gerrit change created: https://git.eclipse.org/r/46704
Comment 2 Fabio Zadrozny CLA 2015-04-28 13:29:19 EDT
Created attachment 252858 [details]
Picture with the patch applied
Comment 4 Lars Vogel CLA 2015-04-28 15:54:01 EDT
Thanks Fabio. Looks good and AFAIK no API is changed.
Comment 5 Mchael Pujos CLA 2015-05-15 18:03:03 EDT
On the 'patch applied' image, there's a white outline on the edge (also confirming this is the case on Mac, using 4.5M7).
It doesn't look very good and seems like a graphical glitch. Can we have it fixed ?
Comment 6 Lars Vogel CLA 2015-05-16 06:35:12 EDT
(In reply to Mchael Pujos from comment #5)
> On the 'patch applied' image, there's a white outline on the edge (also
> confirming this is the case on Mac, using 4.5M7).
> It doesn't look very good and seems like a graphical glitch. Can we have it
> fixed ?

Can you upload a screenshot?
Comment 7 Mchael Pujos CLA 2015-05-16 07:02:27 EDT
It is visible in the screenshot attached to this issue:

https://bugs.eclipse.org/bugs/attachment.cgi?id=252858

Notice the white lines on the left and right edges of the Hovered tab.