Community
Participate
Working Groups
Taken out of Bug 389564
Assigning it to 4.6 right now as 4.5 SR1 is not available as the Target Milestone.
I would like to have your input about this. The change that triggered this ticket is actually not an additional functionality or methods but it is a fix. And when I use jacoco, I see that the changed lines are already covered by the current tests. Do you think an additional test case is needed?
Look at it this way, if the functionality was not there, what test case would have failed ? The lines might be already covered with different input/environment parameters which were running fine before also. Same tests we can add with input/environment parameters which would have failed without this fix but do not fail now.
Sarika, I see your point, but I will need your help to figure this out. The difficulty is that the initial bug was associated with a specific setup consisting of a multi-user eclipse installation where the user home is located on a Windows shared folder. I was able to verify the fix because I have that configuration in place. But is it possible to simulate this configuration using on the current testing framework? Do you think there are tests that we can change the inputs in order to simulate this scenario?
May be You can try adding an Ant Home entry invoking Ant Preference Manager code with url and then check if it comes up as expected.
New Gerrit change created: https://git.eclipse.org/r/48227
(In reply to Eclipse Genie from comment #6) > New Gerrit change created: https://git.eclipse.org/r/48227 Looks good, will have to wait to put this till we get 4.6 Stream.
Julian, I am not to merge and rebase the changes. Julian Enoch <xxxxxxxxx@ericsson.com>, is it registered to gerrit and CLA ?
(In reply to Sarika Sinha from comment #8) > Julian Enoch <xxxxxxxxx@ericsson.com>, is it registered to gerrit and CLA > ? Sarika, I have submitted the change as xxxxxxxxx@ericsson.com. My email in the CLA has changed now to xxxxxxxxx@gmail.com.
Can you submit the gerrit patch with gmail id then ?
Do you plan to provide the patch with new ID ?
(In reply to Sarika Sinha from comment #11) > Do you plan to provide the patch with new ID ? I will look into it. sorry I have been busy lately.
We at the closure of 4.6, so will appreciate if you can take it on priority.
New Gerrit change created: https://git.eclipse.org/r/72423
Thanks for the email id update. Test work fine on Linux but with other OS we will see path problems. May be we can use assertFalse("Incorrect classpath entry. This would have been the value before the fix", resultedEntries[entries.length].getLabel().equals(new Path("/home/tom/.eclipse/3.8/configuration/org.eclipse.osgi/bundles/21/2/.cp/lib/remote.jar").toOSString())); //$NON-NLS-1$ //$NON-NLS-2$ assertTrue("Incorrect classpath entry", resultedEntries[entries.length].getLabel().equals(new Path("//hub/home/tom/.eclipse/3.8/configuration/org.eclipse.osgi/bundles/21/2/.cp/lib/remote.jar").toOSString())); //$NON-NLS-1$ //$NON-NLS-2$ Let me know if you have better solution.
(In reply to Sarika Sinha from comment #15) > Thanks for the email id update. > > Test work fine on Linux but with other OS we will see path problems. > > May be we can use > assertFalse("Incorrect classpath entry. This would have been the value > before the fix", resultedEntries[entries.length].getLabel().equals(new > Path("/home/tom/.eclipse/3.8/configuration/org.eclipse.osgi/bundles/21/2/.cp/ > lib/remote.jar").toOSString())); //$NON-NLS-1$ //$NON-NLS-2$ > assertTrue("Incorrect classpath entry", > resultedEntries[entries.length].getLabel().equals(new > Path("//hub/home/tom/.eclipse/3.8/configuration/org.eclipse.osgi/bundles/21/ > 2/.cp/lib/remote.jar").toOSString())); //$NON-NLS-1$ //$NON-NLS-2$ > > Let me know if you have better solution. Looks very good to me. Please go ahead with this change.
Gerrit patch has been corrected accordingly. Test case passes on Windows and Linux.
Gerrit change https://git.eclipse.org/r/72423 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=01882362e030384bed5aa4911c32b654040f9f88
Thanks Julian!!
http://download.eclipse.org/eclipse/downloads/drops4/I20160519-1100/testresults/html/org.eclipse.ant.tests.core_ep46I-unit-cen64_linux.gtk.x86_64_8.0.html Linux test case fails for path comparison. Will have to test on Linux/Mac to see the difference in string.
New Gerrit change created: https://git.eclipse.org/r/73436
Reason was simple - For Windows , remote path starts with "//hub" but in linux and Mac it starts with "/hub". Unfortunately toOSString just handles the forward and backward slash problem of OS path. Our main aim of this test case is that it should not start with "/home" and it should have the machine details "hub". So changed the test case a bit to confirm for the machine details and compare the string after stripping the initial slashes.
Ran the tests independently on Windows/Linux and Mac to verify.
Released the changes - http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=f36f9c3b5e8a38e5f26e1d29c9147ca5c56725d2
Verified with http://download.eclipse.org/eclipse/downloads/drops4/I20160524-2000/testResults.php
This thread cites my personal email in comments #c8 and #c9, and can be fetched from search engines, which causes me to receive a lot of spam.
(In reply to Julian Enoch from comment #26) > This thread cites my personal email in comments #c8 and #c9, and can be > fetched from search engines, which causes me to receive a lot of spam. How do you know it comes from those comments?
Reopening to reset VERIFIED state.
Created attachment 273723 [details] Google search
(In reply to Dani Megert from comment #27) > How do you know it comes from those comments? Dani, I cannot tell for sure but I when I google it the only locations that I get are Bugzilla and Gerrit (see attachment in previous comment). It makes me think that may be these platforms should not be accessible to search engines which makes them vulnerable to malicious web crawlers. For now, I would like if I was able to delete the comments in question!
(In reply to Julian Enoch from comment #30) > (In reply to Dani Megert from comment #27) > > How do you know it comes from those comments? > > Dani, I cannot tell for sure but I when I google it the only locations that > I get are Bugzilla and Gerrit (see attachment in previous comment). > > It makes me think that may be these platforms should not be accessible to > search engines which makes them vulnerable to malicious web crawlers. > > For now, I would like if I was able to delete the comments in question! Hi Julian. I suggest to file two bug reports against https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Community&component=Bugzilla 1) To shadow your e-mail address in the comments of this bug. 2) For a general solution to hide them from search engines. Please cc me on those. Thanks.
