Bug 465460 - Missing welcome_banner.png in org.eclipse.ui.ide.application
Summary: Missing welcome_banner.png in org.eclipse.ui.ide.application
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 4.5 M7   Edit
Assignee: Tony McCrary CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatfix
Depends on:
Blocks:
 
Reported: 2015-04-24 17:27 EDT by Markus Keller CLA
Modified: 2015-04-29 05:19 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2015-04-24 17:27:28 EDT 
org.eclipse.ui.internal.ide.application.IDEWorkbenchAdvisor.declareWorkbenchImages() contains this code, but no such png is available:

declareWorkbenchImage(ideBundle,
		IDEInternalWorkbenchImages.IMG_OBJS_WELCOME_BANNER, PATH_OBJECT
				+ "welcome_banner.png", true); //$NON-NLS-1$

The /org.eclipse.ui.ide/icons/full/obj16/welcome_banner.gif is still there.

I not sure if the image is actually used anywhere. The WelcomeEditor looks dead.
Comment 1 Lars Vogel CLA 2015-04-25 11:11:39 EDT 
Tony, can you create the png icon?
Comment 2 Eclipse Genie CLA 2015-04-26 20:51:03 EDT 
New Gerrit change created: https://git.eclipse.org/r/46526
Comment 4 Eclipse Genie CLA 2015-04-28 03:36:26 EDT 
New Gerrit change created: https://git.eclipse.org/r/46632
Comment 5 Lars Vogel CLA 2015-04-28 03:37:33 EDT 
Thanks Tony and Markus, I copied Tonys icon to the org.eclipse.ui.ide/icons/full/obj16 directory and will apply that after our test days today.

https://git.eclipse.org/r/46632
Comment 7 Lars Vogel CLA 2015-04-29 05:19:10 EDT 
.
Comment 8 Lars Vogel CLA 2015-04-29 05:19:28 EDT 
png now available in the code base