Bug 465448 - [Examples] Fix compiler warnings in org.eclipse.ui.examples.job
Summary: [Examples] Fix compiler warnings in org.eclipse.ui.examples.job
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.5   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.7 M2   Edit
Assignee: Hilger Steenblock CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2015-04-24 14:12 EDT by Hilger Steenblock CLA
Modified: 2016-08-17 07:19 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hilger Steenblock CLA 2015-04-24 14:12:22 EDT 
Due to the update to java 1.6 there are lots of compiler warnings
Comment 1 Patrik Suzzi CLA 2015-11-17 19:05:02 EST 
I gave a quick look at the errors. There is a big list of items to fix.

I plan starting by converting generics, and by fixing comments. 

I have a question on comments: How to proceed in case of a Missing coment for public declaration in a class: You prefer a suppresswarning, or an Empty Javadoc comment?
Comment 2 Brian de Alwis CLA 2015-11-24 11:05:09 EST 
Since these are examples, perhaps its best to disable the missing-comment-on-public-method.
Comment 3 Lars Vogel CLA 2015-11-24 11:26:56 EST 
(In reply to Brian de Alwis from comment #2)
> Since these are examples, perhaps its best to disable the
> missing-comment-on-public-method.

+1
Comment 4 Patrik Suzzi CLA 2016-01-22 16:34:22 EST 
I saw Hilger had problems with Gerrit ( see 478110 )

I think there is still his Gerrit Change Pending.
Comment 6 Lars Vogel CLA 2016-08-17 07:19:14 EDT 
Thanks Hilger.